Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Mixed precision: scheduler and optimizer are called in the wr… #5997

Conversation

javierlorenzod
Copy link

…ong order (#5558)

What does this PR do?

Fixes # (issue) <- this links related issue to this PR

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #5997 (d48c850) into master (6dba266) will decrease coverage by 44%.
The diff coverage is 26%.

@@           Coverage Diff            @@
##           master   #5997     +/-   ##
========================================
- Coverage      90%     46%    -44%     
========================================
  Files         170     160     -10     
  Lines       11784   11203    -581     
========================================
- Hits        10664    5205   -5459     
- Misses       1120    5998   +4878     

@pep8speaks
Copy link

Hello @javierlorenzod! Thanks for updating this PR.

Line 76:21: E113 unexpected indentation

@javierlorenzod javierlorenzod deleted the bugfix/5558_scheduler-warning branch February 17, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants