Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3.0rc1 #6925

Merged
merged 2 commits into from Apr 9, 2021
Merged

v1.3.0rc1 #6925

merged 2 commits into from Apr 9, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Apr 9, 2021

What does this PR do?

we had bug in nightly releases after #6590 so no nightly was released and prepared 1.3.0rc0 was shout over midnight as nitgly :D

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added bug Something isn't working ci Continuous Integration Important refactor labels Apr 9, 2021
@Borda Borda added this to the 1.3 milestone Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #6925 (4c30f62) into master (5552503) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #6925   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         194     194           
  Lines       12347   12347           
======================================
- Hits        11325   11299   -26     
- Misses       1022    1048   +26     

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is __info__.py some sort of convention?

@Borda
Copy link
Member Author

Borda commented Apr 9, 2021

Is __info__.py some sort of convention?

not really, any better name is welcome :]

@Borda
Copy link
Member Author

Borda commented Apr 9, 2021

tests are failing because of #6762

@Borda Borda added the _Will label Apr 9, 2021
@lexierule lexierule merged commit 3baac71 into master Apr 9, 2021
@lexierule lexierule deleted the v1.3.0rc branch April 9, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants