Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ddp_spawn dataloader checks on windows #6930

Merged
merged 6 commits into from Apr 9, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Apr 9, 2021

What does this PR do?

Fixes current failing windows tests

The fix is removing the on_windows skip. I don't know why we were skipping it.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@carmocca carmocca added this to the 1.3 milestone Apr 9, 2021
@carmocca carmocca added the ci Continuous Integration label Apr 9, 2021
@carmocca carmocca changed the title Run checks on windows Run ddp_spawn dataloader checks on windows Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #6930 (90cf064) into master (3baac71) will decrease coverage by 4%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #6930    +/-   ##
=======================================
- Coverage      92%     87%    -4%     
=======================================
  Files         194     194            
  Lines       12347   12345     -2     
=======================================
- Hits        11322   10774   -548     
- Misses       1025    1571   +546     

@carmocca carmocca marked this pull request as ready for review April 9, 2021 16:48
@carmocca carmocca added the feature Is an improvement or enhancement label Apr 9, 2021
@carmocca carmocca self-assigned this Apr 9, 2021
@Borda
Copy link
Member

Borda commented Apr 9, 2021

@carmocca does this affect Horovod somehow?

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca
Copy link
Contributor Author

carmocca commented Apr 9, 2021

@carmocca does this affect Horovod somehow?

No, the Horovod failure is unrelated. Probably another flaky test

@carmocca carmocca enabled auto-merge (squash) April 9, 2021 17:07
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems you fixed Win but broke Linux

@carmocca carmocca disabled auto-merge April 9, 2021 17:14
@carmocca carmocca enabled auto-merge (squash) April 9, 2021 17:26
@carmocca carmocca merged commit b85cfbe into master Apr 9, 2021
@carmocca carmocca deleted the fix-master-windows-tests branch April 9, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants