Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Add Loops Restart #8131

Closed
wants to merge 668 commits into from
Closed

[Feat] Add Loops Restart #8131

wants to merge 668 commits into from

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Jun 25, 2021

What does this PR do?

Fixes #8126.

TODOS:
[x] Add restart for training epoch loop
[x] Add restart for training batch loop
[x] Add restart for multiple optimizers
[x] Add support random samplers
[x] Add support accumulate_grad_batches (saving gradients)
[x] Add checkpoint creation on failure
[x] Add mechanism to prevent DDP deadlock on failure: Merged #8167
[x] Add restart for validation epoch loop
[x] Add restart for the validation batch loop
[x] Add restart for multiple validation dataloaders
[x] Add val_check_internval
[x] Add FastForwardSampler and CaptureIterativeDataset to recover dataset states. # #8307
[] Add support for results / extras on epoch_end for train
[] Add restore / restarting attribute function to Loops
[] Link progress tracking to Loop attributes
[] Investigate InfiniBatch for random seed (num_workers, ddp sampler)
[] Handle manual optimizer step (optimizer step / zero grad to take care of)
[] Test DistributedSampler
[] Add configuration mechanism to restart as currently supported. Start from next epoch.
[] Restart validation loop using should_check_val.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton mentioned this pull request Jul 9, 2021
12 tasks
@tchaton
Copy link
Contributor Author

tchaton commented Jul 10, 2021

This PR is closed in favour of #8337

@tchaton tchaton closed this Jul 10, 2021
@carmocca carmocca deleted the training_restart branch July 26, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModelCheckpoint does not save checkpoint on training end
6 participants