Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix save/load/resume from checkpoint for DeepSpeed Plugin #8397

Merged
merged 75 commits into from Aug 2, 2021
Merged

Fix save/load/resume from checkpoint for DeepSpeed Plugin #8397

merged 75 commits into from Aug 2, 2021

Commits on Jul 7, 2021

  1. wip

    SeanNaren committed Jul 7, 2021
    Copy the full SHA
    24a3e50 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Change trainer loading behaviour for validate/test/predict

    SeanNaren committed Jul 9, 2021
    Copy the full SHA
    03a8769 View commit details
    Browse the repository at this point in the history

  2. Fix

    SeanNaren committed Jul 9, 2021
    Copy the full SHA
    a943e33 View commit details
    Browse the repository at this point in the history

  3. Fix/add tests

    SeanNaren committed Jul 9, 2021
    Copy the full SHA
    40a3446 View commit details
    Browse the repository at this point in the history

  4. remove

    SeanNaren committed Jul 9, 2021
    Copy the full SHA
    8c24ffd View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2021

  1. Cleanups

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    1879be7 View commit details
    Browse the repository at this point in the history

  2. Space

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    3162ff7 View commit details
    Browse the repository at this point in the history

  3. cleanups

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    6dd61d6 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feat/ckpt_load

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    5772e17 View commit details
    Browse the repository at this point in the history

  5. Add CHANGELOG.md

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    b072868 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into feat/ckpt_load

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    de2738d View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feat/ckpt_load' into fix/ds_saving_2

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    6910e39 View commit details
    Browse the repository at this point in the history

  8. Fix

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    bf5afe3 View commit details
    Browse the repository at this point in the history

  9. Move after setup

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    f2ee8b5 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'feat/ckpt_load' into fix/ds_saving_2

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    b7c24d9 View commit details
    Browse the repository at this point in the history

  11. Cleanups on logic

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    8659426 View commit details
    Browse the repository at this point in the history

  12. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 12, 2021
    Copy the full SHA
    84d20f5 View commit details
    Browse the repository at this point in the history

  13. Remve

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    9e367fd View commit details
    Browse the repository at this point in the history

  14. Merge branch 'feat/ckpt_load' into fix/ds_saving_2

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    6ea8b44 View commit details
    Browse the repository at this point in the history

  15. Remve

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    3f8c3d3 View commit details
    Browse the repository at this point in the history

  16. fix test

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    b8ffc39 View commit details
    Browse the repository at this point in the history

  17. feedback

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    b02f35b View commit details
    Browse the repository at this point in the history

  18. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 12, 2021
    Copy the full SHA
    dbb03af View commit details
    Browse the repository at this point in the history

  19. Update pytorch_lightning/trainer/properties.py 

    Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
    @carmocca
    Sean Naren and carmocca committed Jul 12, 2021
    Copy the full SHA
    1c7b9a1 View commit details
    Browse the repository at this point in the history

  20. Feedback

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    444fb55 View commit details
    Browse the repository at this point in the history

  21. Same fix

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    4632bba View commit details
    Browse the repository at this point in the history

  22. Same fix

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    e92b757 View commit details
    Browse the repository at this point in the history

  23. Add test for behaviour, modify based on feedback

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    66bea8e View commit details
    Browse the repository at this point in the history

  24. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 12, 2021
    Copy the full SHA
    0139a19 View commit details
    Browse the repository at this point in the history

  25. Wording

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    d48d916 View commit details
    Browse the repository at this point in the history

  26. Apply suggestions from code review 

    Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Carlos Mochol铆 <carlossmocholi@gmail.com>
    @kaushikb11 @carmocca
    3 people committed Jul 12, 2021
    Copy the full SHA
    100d73b View commit details
    Browse the repository at this point in the history

  27. Cleanup docs

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    f3f92a5 View commit details
    Browse the repository at this point in the history

  28. Update pytorch_lightning/trainer/trainer.py 

    Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
    @kaushikb11
    Sean Naren and kaushikb11 committed Jul 12, 2021
    Copy the full SHA
    2849d0b View commit details
    Browse the repository at this point in the history

  29. feedback

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    f53c896 View commit details
    Browse the repository at this point in the history

  30. Fixes to test API

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    ebc713b View commit details
    Browse the repository at this point in the history

  31. Add carlos description

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    76e22c2 View commit details
    Browse the repository at this point in the history

  32. Merge branch 'feat/ckpt_load' into fix/ds_saving_2

    SeanNaren committed Jul 12, 2021
    Copy the full SHA
    9a62650 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Fixes

    SeanNaren committed Jul 13, 2021
    Copy the full SHA
    0b46226 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/ds_saving_2

    SeanNaren committed Jul 13, 2021
    Copy the full SHA
    7a85b44 View commit details
    Browse the repository at this point in the history

  3. Changes

    SeanNaren committed Jul 13, 2021
    Copy the full SHA
    8042fb4 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 13, 2021
    Copy the full SHA
    203fd49 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Try delaying

    SeanNaren committed Jul 14, 2021
    Copy the full SHA
    8d0f260 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/ds_saving_2

    SeanNaren committed Jul 14, 2021
    Copy the full SHA
    d4e2295 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Fixes

    SeanNaren committed Jul 27, 2021
    Copy the full SHA
    28d7575 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/ds_saving_2 

    # Conflicts:
#	pytorch_lightning/plugins/training_type/deepspeed.py
#	pytorch_lightning/trainer/connectors/checkpoint_connector.py
#	pytorch_lightning/trainer/properties.py
#	pytorch_lightning/trainer/trainer.py
#	tests/plugins/test_deepspeed_plugin.py
#	tests/trainer/test_dataloaders.py
    SeanNaren committed Jul 27, 2021
    Copy the full SHA
    32f73e4 View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jul 27, 2021
    Copy the full SHA
    a3c6009 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix/ds_saving_2

    SeanNaren committed Jul 27, 2021
    Copy the full SHA
    857a6aa View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Merge branch 'master' into fix/ds_saving_2 

    # Conflicts:
#	docs/source/common/test_set.rst
#	pytorch_lightning/trainer/trainer.py
    SeanNaren committed Jul 28, 2021
    Copy the full SHA
    e6c3bd1 View commit details
    Browse the repository at this point in the history

  2. fixes

    SeanNaren committed Jul 28, 2021
    Copy the full SHA
    c51033a View commit details
    Browse the repository at this point in the history

  3. Add extra condition

    SeanNaren committed Jul 28, 2021
    Copy the full SHA
    4f5bd96 View commit details
    Browse the repository at this point in the history

  4. Fix

    SeanNaren committed Jul 28, 2021
    Copy the full SHA
    e1fb2f0 View commit details
    Browse the repository at this point in the history

  5. Fix

    SeanNaren committed Jul 28, 2021
    Copy the full SHA
    77036a2 View commit details
    Browse the repository at this point in the history

  6. Attempt to fix tests

    SeanNaren committed Jul 28, 2021
    Copy the full SHA
    82e00be View commit details
    Browse the repository at this point in the history

  7. Add guard

    SeanNaren committed Jul 28, 2021
    Copy the full SHA
    57355aa View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Fix test

    SeanNaren committed Jul 29, 2021
    Copy the full SHA
    3fc8f67 View commit details
    Browse the repository at this point in the history

  2. Fix

    SeanNaren committed Jul 29, 2021
    Copy the full SHA
    6adb83d View commit details
    Browse the repository at this point in the history

  3. Add test

    SeanNaren committed Jul 29, 2021
    Copy the full SHA
    607aef2 View commit details
    Browse the repository at this point in the history

  4. Update pytorch_lightning/plugins/training_type/deepspeed.py

    Sean Naren committed Jul 29, 2021
    Copy the full SHA
    0c30656 View commit details
    Browse the repository at this point in the history

  5. Fix description

    SeanNaren committed Jul 29, 2021
    Copy the full SHA
    c9849e0 View commit details
    Browse the repository at this point in the history

  6. Add test

    SeanNaren committed Jul 29, 2021
    Copy the full SHA
    0d3866c View commit details
    Browse the repository at this point in the history

  7. Fix test

    SeanNaren committed Jul 29, 2021
    Copy the full SHA
    fd7a168 View commit details
    Browse the repository at this point in the history

  8. Refactors

    SeanNaren committed Jul 29, 2021
    Copy the full SHA
    256b145 View commit details
    Browse the repository at this point in the history

  9. add recursive

    SeanNaren committed Jul 29, 2021
    Copy the full SHA
    c189595 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Merge branch 'master' into fix/ds_saving_2 

    # Conflicts:
#	pytorch_lightning/accelerators/accelerator.py
#	pytorch_lightning/plugins/training_type/training_type_plugin.py
#	pytorch_lightning/trainer/trainer.py
    SeanNaren committed Jul 30, 2021
    Copy the full SHA
    670810f View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2021

  1. Merge branch 'master' into fix/ds_saving_2

    SeanNaren committed Aug 2, 2021
    Copy the full SHA
    64a4eba View commit details
    Browse the repository at this point in the history

  2. Fix dupe

    SeanNaren committed Aug 2, 2021
    Copy the full SHA
    0d2ec03 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix/ds_saving_2

    SeanNaren committed Aug 2, 2021
    Copy the full SHA
    ef33d90 View commit details
    Browse the repository at this point in the history

  4. Force 0.4.3

    SeanNaren committed Aug 2, 2021
    Copy the full SHA
    5329c48 View commit details
    Browse the repository at this point in the history

  5. Address reviews

    SeanNaren committed Aug 2, 2021
    Copy the full SHA
    95d1287 View commit details
    Browse the repository at this point in the history

  6. Add todo

    SeanNaren committed Aug 2, 2021
    Copy the full SHA
    88ab306 View commit details
    Browse the repository at this point in the history

  7. Update pytorch_lightning/plugins/training_type/training_type_plugin.py

    Sean Naren committed Aug 2, 2021
    Copy the full SHA
    a15cd8d View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Adrian W盲lchli <aedu.waelchli@gmail.com>
    @awaelchli
    Sean Naren and awaelchli committed Aug 2, 2021
    Copy the full SHA
    9365cc0 View commit details
    Browse the repository at this point in the history

  9. Add asserts for properties, address reviews

    SeanNaren committed Aug 2, 2021
    Copy the full SHA
    5f994c4 View commit details
    Browse the repository at this point in the history

  10. Fix description

    SeanNaren committed Aug 2, 2021
    Copy the full SHA
    cdf8c25 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into fix/ds_saving_2

    Sean Naren committed Aug 2, 2021
    Copy the full SHA
    c47abf2 View commit details
    Browse the repository at this point in the history