Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: validate JSON & fix benchmark #8567

Merged
merged 8 commits into from
Jul 28, 2021
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .azure-pipelines/gpu-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ jobs:
testRunTitle: '$(Agent.OS) - $(Build.DefinitionName) - Python $(python.version)'
condition: succeededOrFailed()

- task: PublishCodeCoverageResults@1
- task: PublishCodeCoverageResults@2
displayName: 'Publish coverage report'
inputs:
codeCoverageTool: 'cobertura'
codeCoverageTool: 'Cobertura'
summaryFileLocation: 'coverage.xml'
reportDirectory: '$(Build.SourcesDirectory)/htmlcov'
testRunTitle: '$(Agent.OS) - $(Build.BuildNumber)[$(Agent.JobName)] - Python $(python.version)'
Expand Down
23 changes: 10 additions & 13 deletions .azure-pipelines/gpu_benchmark.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,18 @@
name: GPU Parity testing

on:
schedule:
- cron: "0 0 * * *" # At the end of every day
schedule:
- cron: "0 0 * * *" # At the end of every day
displayName: Daily midnight benchmark
branches:
include:
- master

jobs:
parity-test:
timeoutInMinutes: 120

cancelTimeoutInMinutes: 2

- job: benchmarks
timeoutInMinutes: "90"
cancelTimeoutInMinutes: "2"
pool: gridai-spot-pool

container:
# base ML image: mcr.microsoft.com/azureml/openmpi3.1.2-cuda10.2-cudnn8-ubuntu18.04
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.8-torch1.6"

image: "pytorchlightning/pytorch_lightning:base-cuda-py3.8-torch1.8"
workspace:
clean: all

Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/ci_dockers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,21 +123,6 @@ jobs:
push: false
timeout-minutes: 50

build-nvidia:
runs-on: ubuntu-20.04
# todo: temporarily skip as the base container does not fit to agent
if: false
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Build NVIDIA Docker
uses: docker/build-push-action@v2
with:
file: dockers/nvidia/Dockerfile
push: false
timeout-minutes: 50

build-ipu:
runs-on: ubuntu-20.04
strategy:
Expand Down
24 changes: 24 additions & 0 deletions .github/workflows/ci_schema.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: CI action schema
on: # Trigger the workflow on push or pull request, but only for the master branch
push: {}
pull_request:
branches: [master, "release/*"]

jobs:
validate-schema:
runs-on: ubuntu-20.04
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Install pkg
run: |
pip install check-jsonschema

- name: GH Workflows
run: |
check-jsonschema .github/workflows/*.yml --schemafile "https://json.schemastore.org/github-workflow"

- name: Azure Pipelines
run: |
check-jsonschema .azure-pipelines/*.yml --schemafile "https://raw.githubusercontent.com/microsoft/azure-pipelines-vscode/v1.188.1/service-schema.json"
24 changes: 0 additions & 24 deletions .github/workflows/events-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,30 +153,6 @@ jobs:
tags: pytorchlightning/pytorch_lightning:base-conda-py${{ matrix.python_version }}-torch${{ matrix.pytorch_version }}
timeout-minutes: 55

docker-NVIDIA:
runs-on: ubuntu-20.04
# todo: temporarily skip as the base container does not fit to agent
if: false
steps:
- name: Checkout
uses: actions/checkout@v2

# https://github.com/docker/setup-buildx-action
# Set up Docker Buildx - to use cache-from and cache-to argument of buildx command
- uses: docker/setup-buildx-action@v1
- name: Login to DockerHub
uses: docker/login-action@v1
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Publish NVIDIA to Docker Hub
uses: docker/build-push-action@v2
with:
file: dockers/nvidia/Dockerfile
tags: nvcr.io/pytorchlightning/pytorch_lightning:latest
timeout-minutes: 55

docker-IPU:
runs-on: ubuntu-20.04
strategy:
Expand Down