Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: validate JSON & fix benchmark #8567

Merged
merged 8 commits into from
Jul 28, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .azure-pipelines/gpu-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@ jobs:
testRunTitle: '$(Agent.OS) - $(Build.DefinitionName) - Python $(python.version)'
condition: succeededOrFailed()

- task: PublishCodeCoverageResults@1
- task: PublishCodeCoverageResults@2
displayName: 'Publish coverage report'
inputs:
codeCoverageTool: 'cobertura'
codeCoverageTool: 'Cobertura'
summaryFileLocation: 'coverage.xml'
reportDirectory: '$(Build.SourcesDirectory)/htmlcov'
testRunTitle: '$(Agent.OS) - $(Build.BuildNumber)[$(Agent.JobName)] - Python $(python.version)'
Expand Down
10 changes: 3 additions & 7 deletions .azure-pipelines/gpu_benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,13 @@ on:
- cron: "0 0 * * *" # At the end of every day

jobs:
parity-test:
timeoutInMinutes: 120

- job: benchmarks
timeoutInMinutes: 90
cancelTimeoutInMinutes: 2

pool: gridai-spot-pool

container:
# base ML image: mcr.microsoft.com/azureml/openmpi3.1.2-cuda10.2-cudnn8-ubuntu18.04
image: "pytorchlightning/pytorch_lightning:base-cuda-py3.8-torch1.6"

image: "pytorchlightning/pytorch_lightning:base-cuda-py3.8-torch1.7"
Borda marked this conversation as resolved.
Show resolved Hide resolved
workspace:
clean: all

Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/ci_dockers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -123,21 +123,6 @@ jobs:
push: false
timeout-minutes: 50

build-nvidia:
runs-on: ubuntu-20.04
# todo: temporarily skip as the base container does not fit to agent
if: false
steps:
- name: Checkout
uses: actions/checkout@v2

- name: Build NVIDIA Docker
uses: docker/build-push-action@v2
with:
file: dockers/nvidia/Dockerfile
push: false
timeout-minutes: 50

build-ipu:
runs-on: ubuntu-20.04
strategy:
Expand Down
24 changes: 0 additions & 24 deletions .github/workflows/events-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -153,30 +153,6 @@ jobs:
tags: pytorchlightning/pytorch_lightning:base-conda-py${{ matrix.python_version }}-torch${{ matrix.pytorch_version }}
timeout-minutes: 55

docker-NVIDIA:
runs-on: ubuntu-20.04
# todo: temporarily skip as the base container does not fit to agent
if: false
steps:
- name: Checkout
uses: actions/checkout@v2

# https://github.com/docker/setup-buildx-action
# Set up Docker Buildx - to use cache-from and cache-to argument of buildx command
- uses: docker/setup-buildx-action@v1
- name: Login to DockerHub
uses: docker/login-action@v1
with:
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_PASSWORD }}

- name: Publish NVIDIA to Docker Hub
uses: docker/build-push-action@v2
with:
file: dockers/nvidia/Dockerfile
tags: nvcr.io/pytorchlightning/pytorch_lightning:latest
timeout-minutes: 55

docker-IPU:
runs-on: ubuntu-20.04
strategy:
Expand Down
10 changes: 10 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,16 @@ repos:
- id: black
name: Format code

- repo: https://github.com/sirosen/check-jsonschema
rev: 0.4.0
hooks:
- id: check-github-workflows # Validate GitHub Workflows against the schema provided by Schemastore
files: ^\.github/workflows/
types: [ yaml ]
- id: check-azure-pipelines # Validate Azure Pipelines config against the schema provided by Microsoft
files: ^\.azure-pipelines/
types: [ yaml ]
Borda marked this conversation as resolved.
Show resolved Hide resolved

- repo: https://github.com/PyCQA/flake8
rev: 3.9.2
hooks:
Expand Down