Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip scheduler.step() if optimizer.step() isn't called in the iteration #9923

Closed
wants to merge 36 commits into from
Closed

Skip scheduler.step() if optimizer.step() isn't called in the iteration #9923

wants to merge 36 commits into from

Commits on Oct 13, 2021

  1. Add tmp test

    @akihironitta
    akihironitta committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    306747c View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. Add comments to test

    @akihironitta
    akihironitta committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    3d367e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. update test

    @akihironitta
    akihironitta committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    91a1226 View commit details
    Browse the repository at this point in the history

  2. update test

    @akihironitta
    akihironitta committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    4882cd2 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2021

  1. Add tmp test

    @akihironitta
    akihironitta committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    184cd7e View commit details
    Browse the repository at this point in the history

  2. update test

    @akihironitta
    akihironitta committed Oct 17, 2021
    Configuration menu
    Copy the full SHA
    ea3b878 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. update test

    @akihironitta
    akihironitta committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    d4b1b6a View commit details
    Browse the repository at this point in the history

  2. Skip scheduler.step() if optimizer.step() isn't called

    @akihironitta
    akihironitta committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    6a72a41 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    48c0c01 View commit details
    Browse the repository at this point in the history

  4. update test name

    @akihironitta
    akihironitta committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    6dbcc66 View commit details
    Browse the repository at this point in the history

  5. disable checkpointing in test

    @akihironitta
    akihironitta committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    849fc18 View commit details
    Browse the repository at this point in the history

  6. update changelog

    @akihironitta
    akihironitta committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    762f795 View commit details
    Browse the repository at this point in the history

  7. set min_gpus=1

    @akihironitta
    akihironitta committed Oct 18, 2021
    Configuration menu
    Copy the full SHA
    dc14315 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2021

  1. Exclude docs/ from default pytest dirs

    @akihironitta
    akihironitta committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    fe98ac2 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Merge branch 'master' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    7432d3e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'tests/update-pytes-config' into bugfix/scheduler-before… 

    …-optimizer
    @akihironitta
    akihironitta committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    4210318 View commit details
    Browse the repository at this point in the history

  3. skip scheduler.step if optimizer.step isnt called

    @akihironitta
    akihironitta committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    f1ab5b3 View commit details
    Browse the repository at this point in the history

  4. update fix

    @akihironitta
    akihironitta committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    a8740df View commit details
    Browse the repository at this point in the history

  5. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    fa4a4ba View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. undo fix

    @akihironitta
    akihironitta committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    abf7feb View commit details
    Browse the repository at this point in the history

  2. Raise error if lr_scheduler.step before optimizer.step

    @akihironitta
    akihironitta committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    4d655c0 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    3863e6c View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2021

  1. Merge branch 'master' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    81b6f1d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    daa9bfd View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. rm dev

    @rohitgr7
    rohitgr7 committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    075c1fb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    22e5925 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'bug/dev_1_10' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    4f61e32 View commit details
    Browse the repository at this point in the history

  4. Detect overflow and skip scheduler.step if overflow

    @akihironitta
    akihironitta committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    4ebea39 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'bugfix/scheduler-before-optimizer' of https://github.co… 

    …m/PyTorchLightning/pytorch-lightning into bugfix/scheduler-before-optimizer
    @akihironitta
    akihironitta committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    91eda79 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    d19db6c View commit details
    Browse the repository at this point in the history

  7. Allow warning

    @akihironitta
    akihironitta committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    747f58e View commit details
    Browse the repository at this point in the history

  8. Merge branch 'bugfix/scheduler-before-optimizer' of github.com:PyTorc… 

    …hLightning/pytorch-lightning into bugfix/scheduler-before-optimizer
    @akihironitta
    akihironitta committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    bd13139 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Merge branch 'master' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    aae3249 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2021

  1. Merge branch 'master' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Nov 18, 2021
    Configuration menu
    Copy the full SHA
    0ebc4de View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. try another way of fix

    @akihironitta
    akihironitta committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    0739a73 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into bugfix/scheduler-before-optimizer

    @akihironitta
    akihironitta committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    d17f89b View commit details
    Browse the repository at this point in the history