Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for pixelwise MSE #2017

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

adamjstewart
Copy link
Contributor

@adamjstewart adamjstewart commented Aug 22, 2023

What does this PR do?

Fixes #2016

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2017.org.readthedocs.build/en/2017/

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #2017 (13b6077) into master (f6760b5) will decrease coverage by 48%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2017     +/-   ##
========================================
- Coverage      87%     39%    -48%     
========================================
  Files         270     270             
  Lines       15574   15572      -2     
========================================
- Hits        13477    6059   -7418     
- Misses       2097    9513   +7416     

@SkafteNicki SkafteNicki added this to the v1.1.x milestone Aug 23, 2023
@mergify mergify bot added the ready label Aug 23, 2023
@SkafteNicki SkafteNicki merged commit 42c748b into Lightning-AI:master Aug 23, 2023
65 checks passed
@adamjstewart adamjstewart deleted the fixes/pixelwise-mse branch August 23, 2023 13:38
matsumotosan pushed a commit to matsumotosan/metrics that referenced this pull request Aug 25, 2023
* Fix support for pixelwise MSE

* Remove unused import

* changelog

---------

Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backwards incompatible change to MSE for pixelwise regression
3 participants