New metric: Normalized Mutual Information Score #2029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
matsumotosan
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
SkafteNicki
reviewed
Aug 30, 2023
src/torchmetrics/functional/clustering/normalized_mutual_info_score.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/clustering/normalized_mutual_info_score.py
Outdated
Show resolved
Hide resolved
src/torchmetrics/functional/clustering/normalized_mutual_info_score.py
Outdated
Show resolved
Hide resolved
SkafteNicki
reviewed
Aug 30, 2023
for more information, see https://pre-commit.ci
…score.py Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
…score.py Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
…score.py Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com>
for more information, see https://pre-commit.ci
SkafteNicki
requested review from
lantiga,
Borda,
justusschock and
stancld
as code owners
SkafteNicki
approved these changes
Aug 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2029 +/- ##
======================================
Coverage 87% 87%
======================================
Files 277 279 +2
Lines 15746 15814 +68
======================================
+ Hits 13657 13718 +61
- Misses 2089 2096 +7 |
Borda
approved these changes
Aug 31, 2023
tests/unittests/clustering/test_normalized_mutual_info_score.py
Outdated
Show resolved
Hide resolved
tests/unittests/clustering/test_normalized_mutual_info_score.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
for more information, see https://pre-commit.ci
matsumotosan
added a commit
to matsumotosan/metrics
that referenced
this pull request
Sep 19, 2023
Co-authored-by: Nicki Skafte Detlefsen <skaftenicki@gmail.com> Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes part of #2003
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2029.org.readthedocs.build/en/2029/