Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: default py3.8 #689

Merged
merged 28 commits into from
Jul 11, 2022
Merged

CI: default py3.8 #689

merged 28 commits into from
Jul 11, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Dec 19, 2021

What does this PR do?

  • add python 3.10
  • set default python 3.8

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added enhancement New feature or request test / CI testing or CI labels Dec 19, 2021
@mergify mergify bot requested a review from a team December 19, 2021 21:15
@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #689 (4cf373e) into master (17014b7) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #689   +/-   ##
=====================================
  Coverage      94%    94%           
=====================================
  Files         182    182           
  Lines        8147   8147           
=====================================
  Hits         7654   7654           
  Misses        493    493           

Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can only use python 3.9!
Torch Binaries are not yet available for 3.10 (neither on pypi nor on https://download.pytorch.org/whl/cpu/torch_stable.html)

.github/workflows/ci_test-full.yml Outdated Show resolved Hide resolved
@Borda
Copy link
Member Author

Borda commented Dec 20, 2021

Can only use python 3.9! Torch Binaries are not yet available for 3.10

yep, I found it too, so this will hang tll they start supporting it :] otherwise, this PR does not make much sense if we still keep 3.9 as the latest python and the PR is called add 3.10 support :]

@Borda Borda dismissed justusschock’s stale review December 20, 2021 09:58

no need, it is blocked on its own by CI tests

@Borda Borda marked this pull request as draft December 22, 2021 10:16
@Borda Borda added this to the v0.8 milestone Jan 6, 2022
@Borda Borda force-pushed the master branch 4 times, most recently from 3a0f7dc to 317182c Compare January 10, 2022 13:05
@Borda Borda self-assigned this Jan 10, 2022
@Borda Borda changed the title CI: add py3.10 & default py3.8 [BLOCKED] CI: add py3.10 & default py3.8 Jan 14, 2022
@Borda
Copy link
Member Author

Borda commented Apr 11, 2022

with running the latest I get:

tests\helpers\testers.py:380: in run_functional_metric_test
    _functional_test(
tests\helpers\testers.py:291: in _functional_test
    sk_result = sk_metric(preds[i].cpu(), target[i].cpu(), **extra_kwargs)
tests\audio\test_si_sdr.py:54: in speechmetrics_si_sdr
    metric = speechmetrics_sisdr(preds[i, j], target[i, j], rate=16000)
C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\speechmetrics\__init__.py:117: in __call__
    result_metric = metric.test(*files, array_rate=rate)
C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\speechmetrics\__init__.py:29: in test
    import resampy
C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\resampy\__init__.py:7: in <module>
    from .core import *
C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\resampy\core.py:9: in <module>
    from .interpn import resample_f
C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\resampy\interpn.py:4: in <module>
    import numba
C:\hostedtoolcache\windows\Python\3.8.10\x64\lib\site-packages\numba\__init__.py:200: in <module>
    _ensure_critical_deps()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

        if numpy_version < (1, 18):
            raise ImportError("Numba needs NumPy 1.18 or greater")
        elif numpy_version > (1, 21):
>           raise ImportError("Numba needs NumPy 1.21 or less")
E           ImportError: Numba needs NumPy 1.21 or less

@Borda
Copy link
Member Author

Borda commented Apr 11, 2022

seem #949 would be a very needed update for this case

@Borda
Copy link
Member Author

Borda commented Apr 11, 2022

now it fails to build the numpy from the source... :/

@SkafteNicki SkafteNicki modified the milestones: v0.8, v0.9 Apr 12, 2022
@SkafteNicki SkafteNicki modified the milestones: v0.9, v0.10 May 11, 2022
@mergify mergify bot removed the has conflicts label Jul 11, 2022
@Borda Borda changed the title CI: add py3.10 & default py3.8 CI: default py3.8 Jul 11, 2022
requirements.txt Outdated Show resolved Hide resolved
@Borda
Copy link
Member Author

Borda commented Jul 11, 2022

as py3.10 was added in #1132 let's just set default py3.8

@Borda Borda disabled auto-merge July 11, 2022 15:57
@Borda Borda merged commit c7b7c46 into master Jul 11, 2022
@Borda Borda deleted the ci/py3.10 branch July 11, 2022 15:57
@mergify mergify bot added the ready label Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants