Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stale ffmpeg ref #178

Closed
wants to merge 1 commit into from
Closed

Conversation

speediedan
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes #177
CI testing / nbval workflow was failing in the dependency installation step (due to stale ffmpeg ref).

Note that the build-docs check will not pass until #176 is merged.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #178 (ce6bf76) into main (3fda6eb) will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #178   +/-   ##
===================================
  Coverage    75%    75%           
===================================
  Files         2      2           
  Lines       370    370           
===================================
  Hits        276    276           
  Misses       94     94           

@Borda Borda added the bug / fix Something isn't working label Jun 13, 2022
@Borda Borda mentioned this pull request Jun 13, 2022
3 tasks
Borda added a commit to speediedan/tutorials that referenced this pull request Jun 13, 2022
@Borda Borda closed this in #175 Jun 13, 2022
Borda added a commit that referenced this pull request Jun 13, 2022
* fix sphinx language warning
* fix stale ffmpeg ref #178

Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI testing workflow dependency installation issue
2 participants