Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Fine-Tuning Scheduler Tutorial Updates for PTL 1.7 #187

Merged
merged 17 commits into from Aug 15, 2022

Conversation

speediedan
Copy link
Contributor

Before submitting

  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

A few minor updates to the Fine-Tuning Scheduler tutorial to better support the release of pytorch-lightning 1.7.x

  • changed "finetuning" uses to "fine-tuning" since closed compound word version remains less common in the research literature for the time being
  • removed use of CLI registry since it is deprecated in PTL 1.7 and simplifies the tutorial
  • removed hydra-core version requirement since the relevant issue has been resolved
  • added a small patch to address #80809 and allow the tutorial to succeed with torch 1.12.0. Despite the recent release of 1.12.1, the tutorial should work with 1.12.0 since a non-trivial number of users will likely continue to have it installed.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #187 (0472d78) into main (58c88a9) will not change coverage.
The diff coverage is n/a.

@@         Coverage Diff         @@
##           main   #187   +/-   ##
===================================
  Coverage    75%    75%           
===================================
  Files         2      2           
  Lines       370    370           
===================================
  Hits        276    276           
  Misses       94     94           

@speediedan speediedan marked this pull request as ready for review August 7, 2022 02:56
@speediedan
Copy link
Contributor Author

FYI, the validate Docs/ build-docs job is only failing due to a single stale pytorch-lightning link on the basic_gan nb

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat !

speediedan and others added 2 commits August 7, 2022 15:51
@Borda Borda added the enhancement New feature or request label Aug 8, 2022
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
@rohitgr7 rohitgr7 enabled auto-merge (squash) August 13, 2022 11:42
@rohitgr7 rohitgr7 merged commit 46d4fbc into Lightning-AI:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants