New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Fine-Tuning Scheduler Tutorial Updates for PTL 1.7 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of `finetuning` to hyphenated compound version `fine-tuning` as that form remains the dominant version for now
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
===================================
Coverage 75% 75%
===================================
Files 2 2
Lines 370 370
===================================
Hits 276 276
Misses 94 94 |
speediedan
requested review from
Borda,
ethanwharris,
rohitgr7,
carmocca and
kaushikb11
as code owners
August 7, 2022 02:56
FYI, the validate Docs/ build-docs job is only failing due to a single stale pytorch-lightning link on the basic_gan nb |
tchaton
approved these changes
Aug 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat !
rohitgr7
approved these changes
Aug 7, 2022
lightning_examples/finetuning-scheduler/finetuning-scheduler.py
Outdated
Show resolved
Hide resolved
lightning_examples/finetuning-scheduler/finetuning-scheduler.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Borda
approved these changes
Aug 8, 2022
lightning_examples/finetuning-scheduler/finetuning-scheduler.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
rohitgr7
reviewed
Aug 12, 2022
Borda
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
A few minor updates to the Fine-Tuning Scheduler tutorial to better support the release of pytorch-lightning 1.7.x
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃