New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine-Tuning Scheduler Tutorial Updates for Lightning 2.0.x #236
Conversation
… and PyTorch 2.0 releases
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
===================================
Coverage 73% 73%
===================================
Files 2 2
Lines 382 382
===================================
Hits 280 280
Misses 102 102 |
@Borda @carmocca @ethanwharris @awaelchli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks a lot for updating
lightning_examples/finetuning-scheduler/finetuning-scheduler.py
Outdated
Show resolved
Hide resolved
lightning_examples/finetuning-scheduler/finetuning-scheduler.py
Outdated
Show resolved
Hide resolved
lightning_examples/finetuning-scheduler/finetuning-scheduler.py
Outdated
Show resolved
Hide resolved
lightning_examples/finetuning-scheduler/finetuning-scheduler.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
A few minor updates to the Fine-Tuning Scheduler Tutorial to simplify it slightly and better accommodate the Lightning and PyTorch 2.0.x releases.
Changed
lightning>=2.0.0
is a dependency offinetuning-scheduler
2.0.0 which this tutorial requires.lightning
package rather than the standalone package. Fine-Tuning Scheduler (FTS) by default depends upon thelightning
package rather than the standalonepytorch-lightning
package beginning with FTS 2.0 (though the latter can still be installed and used similar to Lightning).finetuning-scheduler
2.0.0 to simplify the example.Congrats on the successful Lightning 2.0 launch!! 🚀 🎉
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃