Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rank_zero_only(..., default=) argument #187

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Oct 26, 2023

What does this PR do?

When using rank_zero_only, one might want to return a default object to avoid type errors on non-zero ranks.

Implemented in https://github.com/Lightning-AI/lightning/pull/18848/files#diff-ac4de1893b3d5f27cf2fb2c29c4fffbeee29c7e8bf42c101d5366867fff79ac0R56-R77


馃摎 Documentation preview 馃摎: https://lit-utilities--187.org.readthedocs.build/en/187/

@carmocca carmocca added the enhancement New feature or request label Oct 26, 2023
@carmocca carmocca self-assigned this Oct 26, 2023
@carmocca carmocca merged commit da79221 into main Oct 26, 2023
47 checks passed
@carmocca carmocca deleted the carmocca/rank-zero-default branch October 26, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request package tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants