Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: parametrize source folder #228

Merged
merged 8 commits into from
Feb 27, 2024
Merged

ci: parametrize source folder #228

merged 8 commits into from
Feb 27, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Feb 19, 2024

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

In case not project is not located in the source, it fails with a strange message
https://github.com/Lightning-AI/lit-data/actions/runs/7960094345/job/21728362592?pr=8

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--228.org.readthedocs.build/en/228/

@Borda Borda added bug Something isn't working enhancement New feature or request labels Feb 19, 2024
@github-actions github-actions bot added the ci/cd Continuous integration and delivery label Feb 19, 2024
@Borda Borda merged commit cb95b39 into main Feb 27, 2024
45 checks passed
@Borda Borda deleted the ci/mypy-dir branch February 27, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/cd Continuous integration and delivery enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant