Fix parsing pre-release package versions #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
Borda
approved these changes
Jul 23, 2024
|
plus pls add chlog.. 🐰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we replaced the deprecated
pkg_resourcesversion parsing in #281, we replaced the version comparison. The previous way implicitly handled pre-release version specifications, like1.10.0.dev0+931b44ffor example. This functionality got accidentally lost (but wasn't tested before). This PR restores this so that we don't break version parsing. The added test fails on main.Raised in Lightning-AI/lightning-thunder#809
📚 Documentation preview 📚: https://lit-utilities--292.org.readthedocs.build/en/292/