Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pyproject.toml #92

Merged
merged 5 commits into from
Jan 26, 2023
Merged

Conversation

Ce11an
Copy link
Contributor

@Ce11an Ce11an commented Jan 24, 2023

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Migrate from setup.cfg to pyproject.toml

Fixes #90

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Ofc 馃コ

@Ce11an
Copy link
Contributor Author

Ce11an commented Jan 24, 2023

@Borda - Would you like me to use ruff in utilities? If not, a .flake8 file is needed. Let me know 馃憤馃徎

@Borda
Copy link
Member

Borda commented Jan 25, 2023

Would you like me to use ruff in utilities? If not, a .flake8 file is needed. Let me know 馃憤馃徎

sweet! let's also use ruff :)

@Ce11an
Copy link
Contributor Author

Ce11an commented Jan 25, 2023

Hey @Borda,

I have added ruff. Like metrics, do you want to migrate pydocstyle and isort in separate PRs? I believe pre-commit does not read the pyproject.toml for run configurations, so .pre-commit-config.yaml should be updated to reflect the pyproject.toml.

Let me know 馃憤馃徎

@Ce11an Ce11an marked this pull request as ready for review January 25, 2023 20:38
@akihironitta
Copy link
Contributor

@Ce11an Thank you for working on this!

I believe pre-commit does not read the pyproject.toml for run configurations, so .pre-commit-config.yaml should be updated to reflect the pyproject.toml.

I haven't tried, but I think there is no need to reflect any changes in pyproject.toml to pre-commit-config.yaml as isort/black/ruff etc. called by pre-commit automatically read their configuration in pyproject.toml, no?

@Borda
Copy link
Member

Borda commented Jan 26, 2023

do you want to migrate pydocstyle and isort in separate PRs?

yes, let's do it separately and keep PRs rather more focused :)

I believe pre-commit does not read the pyproject.toml for run configurations, so .pre-commit-config.yaml should be updated to reflect the pyproject.toml.

it does, as you can simply check it adding some super strict check, like the D or SIM

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@Borda Borda enabled auto-merge (squash) January 26, 2023 10:11
@Borda Borda merged commit 944f920 into Lightning-AI:main Jan 26, 2023
@Ce11an
Copy link
Contributor Author

Ce11an commented Jan 26, 2023

do you want to migrate pydocstyle and isort in separate PRs?

yes, let's do it separately and keep PRs rather more focused :)

I believe pre-commit does not read the pyproject.toml for run configurations, so .pre-commit-config.yaml should be updated to reflect the pyproject.toml.

it does, as you can simply check it adding some super strict check, like the D or SIM

Ah, awesome. Good to know - thanks!

@Ce11an Ce11an deleted the migrate-to-pyproject.toml branch February 12, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate to pyproject
3 participants