Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing: ignore some cases #21

Merged
merged 3 commits into from
Jul 3, 2023
Merged

typing: ignore some cases #21

merged 3 commits into from
Jul 3, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 3, 2023

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda requested a review from justusschock July 3, 2023 10:57
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #21 (222428d) into main (e800f90) will not change coverage.
The diff coverage is 33%.

Additional details and impacted files
@@        Coverage Diff         @@
##           main   #21   +/-   ##
==================================
  Coverage    86%   86%           
==================================
  Files         3     3           
  Lines       167   167           
==================================
  Hits        144   144           
  Misses       23    23           

@Borda Borda merged commit f5f43d7 into main Jul 3, 2023
14 of 17 checks passed
@Borda Borda deleted the typing branch July 3, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant