Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin pytorch-lightning<1.2 #551

Closed
akihironitta opened this issue Jan 30, 2021 · 13 comments · Fixed by #584
Closed

Unpin pytorch-lightning<1.2 #551

akihironitta opened this issue Jan 30, 2021 · 13 comments · Fixed by #584
Labels
bug Something isn't working ci/cd Continues Integration and delivery model Priority High priority task

Comments

@akihironitta
Copy link
Contributor

pytorch-lightning<1.2 was added in #549 to avoid the following errors.

Description of errors with pytorch-lighting>=1.2

On the current master, the following tests:

test_logistic_regression_model
test_cli_run_log_regression[--max_epochs 1 --max_steps 2]
test_cli_run_self_supervised_simclr[--data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --gpus 0 --fp32 --max_epochs 1 --max_steps 3 --fast_dev_run 1 --batch_size 2 --online_ft]
test_cli_run_self_supervised_byol[ --data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --max_epochs 1 --max_steps 3 --fast_dev_run 1 --batch_size 2 --num_workers 0 --online_ft]
test_cli_run_self_supervised_simsiam[ --dataset cifar10 --data_dir /home/runner/work/pytorch-lightning-bolts/pytorch-lightning-bolts/datasets --max_epochs 1 --max_steps 3 --fast_dev_run 1 --batch_size 2 --num_workers 0 --online_ft --gpus 0 --fp32]

fail with the error:

ValueError: The `preds` should be probabilities, but values were detected outside of [0,1] range.

(Found while fixing ssl tests in #541.)

@akihironitta akihironitta added fix fixing issues... ci/cd Continues Integration and delivery model labels Jan 30, 2021
@Borda Borda added the Priority High priority task label Feb 9, 2021
@Borda
Copy link
Member

Borda commented Feb 9, 2021

Yeah, we shall get compatibility with PL 1.2

@mariaculman18
Copy link

I got the same error, to solve it:

pip uninstall pytorch-lightning
pip install pytorch-lightning==1.1.8

@Borda
Copy link
Member

Borda commented Mar 4, 2021

@ananyahjha93 any update here?

@kaushikb11
Copy link
Contributor

@ananyahjha93 Could you look into it? Would like to try new Lightning features with models in Bolts.

@joseporiolayats
Copy link

Hi, still not working with main and nightly version. It works with 1.1.8

@summelon
Copy link

Any solution with v1.2.6?
Indeed it works on v1.1.8.
While some features I want lose in v1.1.8

@mariaculman18
Copy link

Still not working for v1.3.1

I wanted to use CombinedLoader feature, but had to go back to v1.1.8.

@summelon
Copy link

Still not working for v1.3.1

I wanted to use CombinedLoader feature, but had to go back to v1.1.8.

acc_metric = torchmetrics.Accuracy()
...
acc_now = acc_metric(preds.argmax(dim=1), labels)

For now, this works well for me.

@mariaculman18
Copy link

Still not working for v1.3.1
I wanted to use CombinedLoader feature, but had to go back to v1.1.8.

acc_metric = torchmetrics.Accuracy()
...
acc_now = acc_metric(preds.argmax(dim=1), labels)

For now, this works well for me.

Thanks! Now working on the latest version :D

@talhaanwarch
Copy link

Still not working for v1.3.1
I wanted to use CombinedLoader feature, but had to go back to v1.1.8.

acc_metric = torchmetrics.Accuracy()
...
acc_now = acc_metric(preds.argmax(dim=1), labels)

For now, this works well for me.

but this would not work for multilabel F1 score

@Borda
Copy link
Member

Borda commented Aug 5, 2021

Mind update to the latest TM, shall be fixed and all logits

@yeus
Copy link

yeus commented Aug 7, 2021

Mind update to the latest TM, shall be fixed and all logits

almost. Version 0.4.1 still has the issue with Lightning-AI/torchmetrics#354:

ValueError: The highest label in preds should be smaller than num_classes.

although that issue seems to be fixed in master...

@Borda
Copy link
Member

Borda commented Aug 8, 2021

although that issue seems to be fixed in master...

new TM release is coming next week :]

@Borda Borda added bug Something isn't working and removed fix fixing issues... labels Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/cd Continues Integration and delivery model Priority High priority task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants