Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding required wrapper #1056

Merged
merged 14 commits into from
Jul 12, 2023
Merged

adding required wrapper #1056

merged 14 commits into from
Jul 12, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Jul 11, 2023

What does this PR do?

Wrapper for enforcing certain requirements for a particular class or function.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://lightning-bolts--1056.org.readthedocs.build/en/1056/

@Borda Borda mentioned this pull request Jul 11, 2023
8 tasks
@Borda
Copy link
Member Author

Borda commented Jul 12, 2023

After Lightning-AI/utilities#146 is released we can use it...

@Borda Borda enabled auto-merge (squash) July 12, 2023 09:54
@Borda Borda disabled auto-merge July 12, 2023 20:16
@Borda Borda merged commit b8966d1 into master Jul 12, 2023
29 checks passed
@Borda Borda deleted the feet/requires branch July 12, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant