Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix imports #288

Merged
merged 6 commits into from
Oct 22, 2020
Merged

fix imports #288

merged 6 commits into from
Oct 22, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 19, 2020

What does this PR do?

Fixes #239
Split SSL callback into two files so they can be imported

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@Borda Borda added fix fixing issues... refactoring labels Oct 19, 2020
@codecov
Copy link

codecov bot commented Oct 19, 2020

Codecov Report

Merging #288 into master will increase coverage by 0.06%.
The diff coverage is 96.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #288      +/-   ##
==========================================
+ Coverage   81.85%   81.91%   +0.06%     
==========================================
  Files          98       99       +1     
  Lines        5495     5497       +2     
==========================================
+ Hits         4498     4503       +5     
+ Misses        997      994       -3     
Flag Coverage 螖
#cpu 23.49% <44.82%> (+<0.01%) 猬嗭笍
#pytest 23.49% <44.82%> (+<0.01%) 猬嗭笍
#unittests 81.35% <96.55%> (+0.06%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
pl_bolts/models/self_supervised/cpc/cpc_module.py 20.31% <0.00%> (-0.79%) 猬囷笍
pl_bolts/callbacks/byol_updates.py 100.00% <100.00%> (酶)
pl_bolts/callbacks/ssl_online.py 100.00% <100.00%> (酶)
...l_bolts/models/self_supervised/byol/byol_module.py 84.94% <100.00%> (酶)
...lts/models/self_supervised/simclr/simclr_module.py 82.81% <100.00%> (酶)
...ts/models/self_supervised/swav/swav_online_eval.py 22.95% <100.00%> (+1.63%) 猬嗭笍
...l_bolts/models/rl/vanilla_policy_gradient_model.py 94.64% <0.00%> (+2.67%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update dc16e7b...197e686. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixing issues... refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant