Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: batch_size for MNISTDataModule #331

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

hecoding
Copy link
Contributor

@hecoding hecoding commented Nov 3, 2020

What does this PR do?

Properly fixes #171 fixes #334
batch_size wasn't getting saved at the constructor and thus defaulting to 32. Now it behaves like other datamodules (i.e. CIFAR10DataModule).

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #331 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   82.04%   82.20%   +0.15%     
==========================================
  Files          98       98              
  Lines        5492     5501       +9     
==========================================
+ Hits         4506     4522      +16     
+ Misses        986      979       -7     
Flag Coverage 螖
cpu 24.26% <酶> (+0.01%) 猬嗭笍
pytest 24.26% <酶> (+0.01%) 猬嗭笍
unittests 81.58% <酶> (+0.15%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...l_bolts/models/self_supervised/swav/swav_module.py 73.30% <0.00%> (-1.05%) 猬囷笍
pl_bolts/datamodules/__init__.py 88.67% <0.00%> (+0.67%) 猬嗭笍
...l_bolts/models/rl/vanilla_policy_gradient_model.py 94.64% <0.00%> (+2.67%) 猬嗭笍
pl_bolts/optimizers/lars_scheduling.py 95.74% <0.00%> (+17.02%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d4e6096...580e008. Read the comment docs.

@Borda Borda added the fix fixing issues... label Nov 6, 2020
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datamodule Anything related to datamodules fix fixing issues...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several datamodules ignoring batch_size batch_size for MNISTDataModule
2 participants