update min requirements - PL 1.1.1 #448

Borda · 2020-12-13T22:34:21Z

What does this PR do?

Update req because of Optimizer bus

Before submitting

Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
Did you make sure to update the documentation with your changes?
Did you write any new necessary tests?
Did you verify new and existing tests pass locally with your changes?
If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

codecov · 2020-12-13T22:37:07Z

Codecov Report

Merging #448 (f5a4831) into master (58536c2) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
- Coverage   80.77%   80.39%   -0.39%     
==========================================
  Files         101      101              
  Lines        5706     5676      -30     
==========================================
- Hits         4609     4563      -46     
- Misses       1097     1113      +16

Flag	Coverage Δ
cpu	`24.95% <72.41%> (-0.26%)`	⬇️
pytest	`24.95% <72.41%> (-0.26%)`	⬇️
unittests	`79.98% <100.00%> (-0.08%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pl_bolts/datamodules/experience_source.py	`95.90% <ø> (-0.04%)`	⬇️
pl_bolts/datasets/cifar10_dataset.py	`71.73% <ø> (-25.04%)`	⬇️
pl_bolts/datasets/mnist_dataset.py	`50.00% <ø> (-7.15%)`	⬇️
pl_bolts/callbacks/variational.py	`97.67% <100.00%> (ø)`
pl_bolts/models/rl/common/gym_wrappers.py	`91.45% <100.00%> (+1.53%)`	⬆️
pl_bolts/models/rl/dqn_model.py	`81.06% <100.00%> (+0.94%)`	⬆️
pl_bolts/models/rl/reinforce_model.py	`89.34% <100.00%> (+1.44%)`	⬆️
...l_bolts/models/rl/vanilla_policy_gradient_model.py	`96.36% <100.00%> (+1.72%)`	⬆️
...l_bolts/models/self_supervised/amdim/transforms.py	`100.00% <100.00%> (ø)`
pl_bolts/models/self_supervised/cpc/transforms.py	`100.00% <100.00%> (ø)`
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58536c2...f5a4831. Read the comment docs.

pep8speaks · 2020-12-13T23:23:04Z

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-14 08:43:50 UTC

* update min requirements * rc0 * imports * isort * flake8 * 1.1.1 * flake8 * docs

@akihironitta

* Add DCGAN module * Undo black on conf.py * Add tests for DCGAN * Fix flake8 and codefactor * Add types and small refactoring * Make image sampler callback work * Upgrade DQN to use .log (#404) * Upgrade DQN to use .log * remove unused * pep8 * fixed other dqn * fix loss test case for batch size variation (#402) * Decouple DataModules from Models - CPCV2 (#386) * Decouple dms from CPCV2 * Update tests * Add docstrings, fix import, and update changelog * Update transforms * bugfix: batch_size parameter for DataModules remaining (#344) * bugfix: batch_size for DataModules remaining * Update sklearn datamodule tests * Fix default_transforms. Keep internal for every data module * fix typo on binary_mnist_datamodule thanks @akihironitta Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> * Fix a typo/copy paste error (#415) * Just a Typo (#413) missing a ' at the end of dataset='stl10 * Remove unused arguments (#418) * tests: Use cached datasets in LitMNIST and the doctests (#414) * Use cached datasets * Use cached datasets in doctests * clear replay buffer after trajectory (#425) * stale: update label * bugfix: Add missing imports to pl_bolts/__init__.py (#430) * Add missing imports * Add missing imports * Apply isort * Fix CIFAR num_samples (#432) * Add static type checker mypy to the tests and pre-commit hooks (#433) * Add mypy check to GitHub Actions * Run mypy on pl_bolts only * Add mypy check to pre-commit * Add an empty line at the end of files * Update mypy config * Update mypy config * Update mypy config * show Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> * missing logo * Add type annotations to pl_bolts/__init__.py (#435) * Run mypy on pl_bolts only * Update mypy config * Add type hints to pl_bolts/__init__.py * mypy Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz> * skip hanging (#437) * Option to normalize latent interpolation images (#438) * add option to normalize latent interpolation images * linspace * update Co-authored-by: ananyahjha93 <ananya@pytorchlightning.ai> * 0.2.6rc1 * Warnings fix (#449) * Revert "Merge pull request #1 from ganprad/warnings_fix" This reverts commit 7c5aaf0. * Fixes warning related np.integer in SklearnDataModule Fixes this warning: ```DeprecationWarning: Converting `np.integer` or `np.signedinteger` to a dtype is deprecated. The current result is `np.dtype(np.int_)` which is not strictly correct. Note that the result depends on the system. To ensure stable results use may want to use `np.int64` or `np.int32```` * Refactor datamodules/datasets (#338) * Remove try: ... except: ... * Fix experience_source * Fix imagenet * Fix kitti * Fix sklearn * Fix vocdetection * Fix typo * Remove duplicate * Fix by flake8 * Add optional packages availability vars * binary_mnist * Use pl_bolts._SKLEARN_AVAILABLE * Apply isort * cifar10 * mnist * cityscapes * fashion mnist * ssl_imagenet * stl10 * cifar10 * dummy * fix city * fix stl10 * fix mnist * ssl_amdim * remove unused DataLoader and fix docs * use from ... import ... * fix pragma: no cover * Fix forward reference in annotations * binmnist * Same order as imports * Move vars from __init__ to utils/__init__ * Remove vars from __init__ * Update vars * Apply isort * update min requirements - PL 1.1.1 (#448) * update min requirements * rc0 * imports * isort * flake8 * 1.1.1 * flake8 * docs * Add missing optional packages to `requirements/*.txt` (#450) * Import matplotlib at the top * Add missing optional packages * Update wandb * Add mypy to requirements * update Isort (#457) * Adding flags to datamodules (#388) * Adding flags to datamodules * Finishing up changes * Fixing syntax error * More syntax errors * More * Adding drop_last flag to sklearn test * Adding drop_last flag to sklearn test * Updating doc for reflect drop_last=False * Adding flags to datamodules * Finishing up changes * Fixing syntax error * More syntax errors * More * Adding drop_last flag to sklearn test * Adding drop_last flag to sklearn test * Updating doc for reflect drop_last=False * Cleaning up parameters and docstring * Fixing syntax error * Fixing documentation * Hardcoding shuffle=False for val and test * Add DCGAN module * Small fixes * Remove DataModules * Update docs * Update docs * Update torchvision import * Import gym as optional package to build docs successfully (#458) * Import gym as optional package * Fix import * Apply isort * bugfix: batch_size parameter for DataModules remaining (#344) * bugfix: batch_size for DataModules remaining * Update sklearn datamodule tests * Fix default_transforms. Keep internal for every data module * fix typo on binary_mnist_datamodule thanks @akihironitta Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> * Option to normalize latent interpolation images (#438) * add option to normalize latent interpolation images * linspace * update Co-authored-by: ananyahjha93 <ananya@pytorchlightning.ai> * update min requirements - PL 1.1.1 (#448) * update min requirements * rc0 * imports * isort * flake8 * 1.1.1 * flake8 * docs * Apply suggestions from code review * Apply suggestions from code review * Add docs * Use LSUN instead of CIFAR10 * Update TensorboardGenerativeModelImageSampler * Update docs with lsun * Update test * Revert TensorboardGenerativeModelImageSampler changes * Remove ModelCheckpoint callback and nrow=5 arg * Apply suggestions from code review * Fix test_dcgan * Apply yapf * Apply suggestions from code review Co-authored-by: Teddy Koker <teddy.koker@gmail.com> Co-authored-by: Sidhant Sundrani <sidhant96@outlook.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> Co-authored-by: Héctor Laria <hector_laria@hotmail.com> Co-authored-by: Bartol Karuza <bartol.k@gmail.com> Co-authored-by: Happy Sugar Life <777Jonathansum@gmail.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: Jirka Borovec <jirka.borovec@seznam.cz> Co-authored-by: ananyahjha93 <ananya@pytorchlightning.ai> Co-authored-by: Pradeep Ganesan <ganprad@users.noreply.github.com> Co-authored-by: Brian Ko <briankosw@gmail.com> Co-authored-by: Christoph Clement <christoph.clement@artorg.unibe.ch>

Borda added the fix fixing issues... label Dec 13, 2020

Borda added this to the v0.2.x milestone Dec 13, 2020

Borda changed the title ~~update min requirements~~ update min requirements - PL 1.1.1 Dec 13, 2020

Borda added the Priority High priority task label Dec 13, 2020

Borda requested review from akihironitta and ananyahjha93 and removed request for akihironitta December 13, 2020 23:57

This was referenced Dec 14, 2020

Apply isort to pl_bolts/callbacks/variational.py #441

Merged

Refactor pl_bolts.datamodules and pl_bolts.datasets #338

Merged

akihironitta approved these changes Dec 14, 2020

View reviewed changes

Borda added 5 commits December 14, 2020 09:35

update min requirements

a169d04

rc0

4a10417

imports

6118ca9

isort

f494fb2

flake8

8e1e6bf

Borda force-pushed the min-reg-1.1.1 branch from de50680 to 8e1e6bf Compare December 14, 2020 08:43

akihironitta self-requested a review December 14, 2020 09:16

1.1.1

2b9ea21

Borda marked this pull request as ready for review December 16, 2020 12:32

Borda added 2 commits December 16, 2020 13:41

flake8

860bc7f

docs

f5a4831

Borda merged commit a6a395f into master Dec 16, 2020

Borda deleted the min-reg-1.1.1 branch December 16, 2020 13:57

chris-clem pushed a commit to chris-clem/pytorch-lightning-bolts that referenced this pull request Dec 16, 2020

update min requirements - PL 1.1.1 (Lightning-Universe#448)

78c4d00

* update min requirements * rc0 * imports * isort * flake8 * 1.1.1 * flake8 * docs

chris-clem pushed a commit to chris-clem/pytorch-lightning-bolts that referenced this pull request Dec 17, 2020

update min requirements - PL 1.1.1 (Lightning-Universe#448)

ab89aa0

* update min requirements * rc0 * imports * isort * flake8 * 1.1.1 * flake8 * docs

Borda removed this from the v0.2.x milestone Jan 18, 2021

Borda added this to the v0.3 milestone Jan 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update min requirements - PL 1.1.1 #448

update min requirements - PL 1.1.1 #448

Borda commented Dec 13, 2020

codecov bot commented Dec 13, 2020 •

edited

pep8speaks commented Dec 13, 2020 •

edited

update min requirements - PL 1.1.1 #448

update min requirements - PL 1.1.1 #448

Conversation

Borda commented Dec 13, 2020

What does this PR do?

Before submitting

PR review

Did you have fun?

codecov bot commented Dec 13, 2020 • edited

Codecov Report

pep8speaks commented Dec 13, 2020 • edited

Comment last updated at 2020-12-14 08:43:50 UTC

codecov bot commented Dec 13, 2020 •

edited

pep8speaks commented Dec 13, 2020 •

edited