Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactors - cleaning models #524

Merged
merged 14 commits into from Jan 19, 2021

Conversation

akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jan 18, 2021

What does this PR do?

Closes #519 and closes #476.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@akihironitta akihironitta added this to In progress in Code Health / Refatoring via automation Jan 18, 2021
@github-actions github-actions bot added the model label Jan 18, 2021
@codecov
Copy link

codecov bot commented Jan 18, 2021

Codecov Report

Merging #524 (b8d4c7b) into master (55ab214) will decrease coverage by 1.63%.
The diff coverage is 70.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage   79.16%   77.53%   -1.64%     
==========================================
  Files         114      114              
  Lines        6466     6664     +198     
==========================================
+ Hits         5119     5167      +48     
- Misses       1347     1497     +150     
Flag Coverage 螖
cpu 25.80% <36.36%> (-0.43%) 猬囷笍
pytest 25.80% <36.36%> (-0.43%) 猬囷笍
unittests 77.01% <64.55%> (-1.67%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
pl_bolts/models/gans/dcgan/dcgan_module.py 97.24% <酶> (+0.02%) 猬嗭笍
pl_bolts/models/rl/dqn_model.py 78.48% <0.00%> (-0.50%) 猬囷笍
pl_bolts/transforms/dataset_normalizations.py 85.00% <酶> (+0.78%) 猬嗭笍
pl_bolts/__init__.py 90.00% <33.33%> (-10.00%) 猬囷笍
pl_bolts/callbacks/vision/confused_logit.py 21.91% <33.33%> (-55.01%) 猬囷笍
...bolts/transforms/self_supervised/ssl_transforms.py 95.34% <33.33%> (-4.66%) 猬囷笍
pl_bolts/models/rl/common/gym_wrappers.py 85.49% <45.45%> (-6.11%) 猬囷笍
pl_bolts/models/rl/reinforce_model.py 88.61% <50.00%> (-0.73%) 猬囷笍
...l_bolts/models/rl/vanilla_policy_gradient_model.py 95.49% <50.00%> (+1.85%) 猬嗭笍
...l_bolts/models/self_supervised/amdim/transforms.py 92.94% <50.00%> (-1.11%) 猬囷笍
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 55ab214...b8d4c7b. Read the comment docs.

@akihironitta akihironitta mentioned this pull request Jan 18, 2021
9 tasks
@akihironitta akihironitta marked this pull request as ready for review January 18, 2021 06:02
@Borda Borda added the ready label Jan 18, 2021
@akihironitta akihironitta marked this pull request as draft January 18, 2021 09:36
@akihironitta akihironitta mentioned this pull request Jan 18, 2021
8 tasks
@Borda Borda removed the ready label Jan 18, 2021
@Borda Borda self-requested a review January 18, 2021 09:42
@akihironitta akihironitta marked this pull request as ready for review January 18, 2021 09:46
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
@Borda Borda modified the milestones: v0.3, v0.4 Jan 18, 2021
@akihironitta akihironitta marked this pull request as ready for review January 19, 2021 01:22
@akihironitta
Copy link
Contributor Author

akihironitta commented Jan 19, 2021

@Borda I included some additional refactors as suggested in #476, and this PR should be ready to go. Please have a look :)

@Borda Borda added the ready label Jan 19, 2021
from sklearn.datasets import load_boston
except ModuleNotFoundError as err:
raise ModuleNotFoundError( # pragma: no-cover
else: # pragma: no cover
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there an advantage or using "no cover" compare to "no-cover" I was thinking that the joined form is more like a tag :]

@Borda Borda changed the title Minor refactors - models Minor refactors - cleaning models Jan 19, 2021
@Borda Borda merged commit 6c307c1 into Lightning-Universe:master Jan 19, 2021
Code Health / Refatoring automation moved this from In progress to Done Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Minor refactors of the codebase [coverage] Use no cover instead of no-cover
2 participants