CI: drop code formatters

[Borda]

What does this PR do?

requested by @williamFalcon

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure your PR does only one thing, instead of bundling different changes together?
• Did you make sure to update the documentation with your changes?
• Did you write any new necessary tests? [not needed for typos/docs]
• Did you verify new and existing tests pass locally with your changes?
• If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

• Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[codecov]

Codecov Report

Merging #558 (859565d) into master (86e3f52) will increase coverage by 0.44%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #558      +/-   ##
==========================================
+ Coverage   77.58%   78.03%   +0.44%     
==========================================
  Files         115      115              
  Lines        6701     6701              
==========================================
+ Hits         5199     5229      +30     
+ Misses       1502     1472      -30     

Flag	Coverage Δ
cpu	26.23% <ø> (ø)
pytest	26.23% <ø> (ø)
unittests	77.51% <ø> (+0.44%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pl_bolts/datasets/base_dataset.py	95.45% <0.00%> (+13.63%)	⬆️
pl_bolts/datasets/cifar10_dataset.py	96.77% <0.00%> (+25.80%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86e3f52...34b41de. Read the comment docs.

[akihironitta]

Will we have a different formatter like black (which works great with flake8), or no more formatters in the future?

[Borda]

Will we have a different formatter like black (which works great with flake8), or no more formatters in the future?

good question, personally I am not happy about it, pls ask @ananyahjha93 or @tchaton

[williamFalcon]

we’ll add any formatters that can work automatically for users. but right now this is a blocker for new contributors.

imagine coming to do a simple contribution of a few lines, and you spent the next 2 hours trying to get the build to pass because you have no idea what black, mypy, isort etc are. you walk away and don’t come back because it’s too “hard” to contribute.

so, we lose contributors and gain a few sorted lines... not worth it

[akihironitta]

I see. That totally makes sense.

[tchaton]

LGTM ! Should we add note in PR header to explain how to do formatting if people are interested ?