Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the sparseml callback #724

Merged
merged 8 commits into from
Sep 5, 2021
Merged

Add the sparseml callback #724

merged 8 commits into from
Sep 5, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Sep 3, 2021 •
edited

What does this PR do?

Introduces a SparseML Callback to bolts!

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 馃檭

@github-actions github-actions bot added callback documentation Improvements or additions to documentation labels Sep 3, 2021
Borda
Borda reviewed Sep 3, 2021
View reviewed changes
docs/source/callbacks/sparseml.rst Outdated Show resolved Hide resolved
docs/source/callbacks/sparseml.rst Outdated Show resolved Hide resolved
docs/source/callbacks/sparseml.rst Show resolved Hide resolved
Sean Naren and others added 2 commits September 3, 2021 14:30
@Borda
Apply suggestions from code review
298f193 
Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Add sample model
56b1d45
tchaton
tchaton approved these changes Sep 3, 2021
View reviewed changes
Copy link

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks dope !

ethanwharris
ethanwharris approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃槂

@Borda Borda enabled auto-merge (squash) September 5, 2021 08:41
@Borda Borda merged commit e13f05d into master Sep 5, 2021
@Borda Borda deleted the feat/sparseml branch September 5, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Borda approved these changes

@ethanwharris ethanwharris ethanwharris approved these changes

@tchaton tchaton tchaton approved these changes

@akihironitta akihironitta akihironitta approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@edenlightning edenlightning Awaiting requested review from edenlightning

Assignees
No one assigned
Labels
callback documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@SeanNaren @awaelchli @Borda @ethanwharris @tchaton @akihironitta