Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: install package #909

Merged
merged 6 commits into from Oct 22, 2022
Merged

docs: install package #909

merged 6 commits into from Oct 22, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 22, 2022 •
edited

What does this PR do?

Install the package itself, so all dependencies are there
needed for #907

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the enhancement New feature or request label Oct 22, 2022
@Borda Borda requested a review from otaj October 22, 2022 11:18
@Borda Borda mentioned this pull request Oct 22, 2022
Merged
8 tasks
@mergify mergify bot added the ready label Oct 22, 2022
@Borda Borda merged commit 9e1ebb3 into master Oct 22, 2022
@Borda Borda deleted the ci/docs branch October 22, 2022 17:01
matsumotosan pushed a commit to matsumotosan/lightning-bolts that referenced this pull request Oct 27, 2022
@Borda @pre-commit-ci @matsumotosan
docs: install package (Lightning-Universe#909)
46146d7 
* ci: install package
* use package

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akihironitta akihironitta akihironitta approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris is a code owner

@otaj otaj Awaiting requested review from otaj

Assignees
No one assigned
Labels
enhancement New feature or request ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Borda @akihironitta @rohitgr7