Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
==========================================
- Coverage 90.21% 87.27% -2.95%
==========================================
Files 71 73 +2
Lines 1543 1658 +115
==========================================
+ Hits 1392 1447 +55
- Misses 151 211 +60
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Wow, that's a lot of red. I think I may be able to get rid of the dependency to pytorch-lightning-bolts, which isn't even listed as a dependency yet. Also, @SeanNaren I've tested sparseml with torch 1.9, and it works!? I'll do a more thorough test after my test tomorrow and add the appropriate changes. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
The logger and callback tests need certain imports that aren't in requirements.txt. But I wasn't sure if we wanted to add more import statements. The logger test needs wandb; and the sparseml callback test needs pytorch 1.7-1.8. |
Should I add wandb to requirements.txt? Also, I'm going to update the docs with the different ways to use sparseml soon |
Head branch was pushed to by a user without write access
Thanks for your hard work @mathemusician hopefully tests should pass now, and we can merge :) |
Closes #196
Add option to use sparseml. This is still a little rough around the edges, but I welcome the feedback! Implementation on Google Colab.
Still needs:
MODELS_PATH
andRECIPE_PATH
through Hydra instead of environment variableWill continue to add more changes after my reactions engineering exam tomorrow. Feel free to give me pointers or links to tutorials if you see any changes I need to make.