Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Skip DeepSpeed Optimization if not available or not supported #6

Merged
merged 10 commits into from
Jan 13, 2023
Merged

Skip DeepSpeed Optimization if not available or not supported #6

merged 10 commits into from
Jan 13, 2023

Conversation

tchaton
Copy link

@tchaton tchaton commented Jan 13, 2023 •
edited
Loading

The PR #2 broke inference on MacOs as triton isn't supported.

This PR does the following:

  • turns optimisation off by default
  • make DeepSpeed optional
  • make DeepSpeed and Triton installable only on
  • skip DeepSpeed optimisation if not available or supported.

TODOs:

  • Validate it works with model.predict_step(prompts="text....")
  • Validate inference it works on MacOS
  • Validate inference it works on CPU

@tchaton tchaton added the bug Something isn't working label Jan 13, 2023
@tchaton tchaton mentioned this pull request Jan 13, 2023
Merged
hhsecond
hhsecond approved these changes Jan 13, 2023
View reviewed changes
ldm/lightning.py Outdated Show resolved Hide resolved
@tchaton tchaton merged commit 8d78cc3 into lit Jan 13, 2023
@tchaton tchaton deleted the make_deepspeed_opt_in branch January 13, 2023 11:55
@tchaton tchaton mentioned this pull request Jan 13, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hhsecond hhsecond hhsecond approved these changes

Assignees

@tchaton tchaton

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@tchaton @hhsecond