kintsugi: Fix passing options from install-driver to driver. #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byohay
force-pushed
the
feature/fix-pass-driver-parameters
branch
4 times, most recently
from
99b018f
to
40e39cc
Compare
ashdnazg
reviewed
Apr 9, 2023
lib/kintsugi/cli.rb
Outdated
| @@ -106,8 +104,9 @@ def create_install_driver_subcommand | |||
| end | |||
|
|
|||
| def install_kintsugi_driver_globally(options) | |||
| joined_options = options.count > 1 ? " #{options.join(" ")}" : "" | |||
There was a problem hiding this comment.
shouldn't this just be options.join(" ")?
at the moment it ignores options if it has just one element
There was a problem hiding this comment.
oops, it's supposed to be options.count > 0. The problem is that when is there are no options a trailing space is added which writes the driver command incorrectly:
driver = "kintsugi driver %O %A %B %P "
However I can use .rstrip instead.
byohay
force-pushed
the
feature/fix-pass-driver-parameters
branch
from
40e39cc
to
ffb905f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.