cli: expose all merge settings flags to driver. #102
Conversation
| @@ -171,33 +160,21 @@ def uninstall_kintsugi_driver_globally | |||
| end | |||
There was a problem hiding this comment.
If I pass kintsugi install-driver --allow-duplicates will write the driver command to the gitconfig as:
kintsugi driver %O %A %B %P --allow-duplicates true which is incorrect, because allow-duplcates doesn't accept any parameter. Either add a parameter to allow-duplicates to make it like interactive-resolution or solve this some other way.
ashdnazg
force-pushed
the
feature/reasonable-cli
branch
from
7aa4b13
to
e9625fa
Compare
lib/kintsugi/cli.rb
Outdated
| case switch | ||
| when OptionParser::Switch::NoArgument | ||
| [prefix + option_name.to_s] | ||
| when NilClass |
There was a problem hiding this comment.
Do we want to assume that options are a result of parsing with the option parser? If so, invalid flags will be catched by the parse! method and we don't need to treat this case here.
There was a problem hiding this comment.
I don't want to have an if else situation that will treat nil as either short or long if anything changes somewhere.
lib/kintsugi/cli.rb
Outdated
| else | ||
| [prefix + option_name.to_s, option_value] | ||
| end | ||
| end.compact.flatten |
There was a problem hiding this comment.
Is compact necessary here? It should never happen with the current code
lib/kintsugi/cli.rb
Outdated
| @@ -88,9 +77,23 @@ def create_install_driver_subcommand | |||
| end | |||
|
|
|||
| driver_options = options.map do |option_name, option_value| | |||
There was a problem hiding this comment.
nit: I'd extract this to another function because it's quite long now.
ashdnazg
force-pushed
the
feature/reasonable-cli
branch
from
e9625fa
to
1f87fd6
Compare
|
F&Sed |
No description provided.