apply_change_to_project: Fix adding file to target with existing name. #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Couldn't this swap the files? |
byohay
force-pushed
the
feature/fix-same-filename-different-target
branch
from
3f561fc
to
0e63203
Compare
The bug was reported here: #104 Basically, when a file with a name that already exists is added to a target, the search for the file only took into account the filename. Instead, the file is searched for in `change_source_project` and its group path is taken from there. As a sidenote - Adding the UUID would also help, but would create other sorts of problems because UUIDs are not always consistent between project saves.
byohay
force-pushed
the
feature/fix-same-filename-different-target
branch
from
0e63203
to
5f6e2e5
Compare
ashdnazg
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was reported here: #104
Basically, when a file with a name that already exists is added to a
target, the search for the file only took into account the filename.
Instead, the file is searched for in
change_source_projectand itsgroup path is taken from there.
As a sidenote - Adding the UUID would also help, but would create other
sorts of problems because UUIDs are not always consistent between
project saves.