Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcodeproj_extensions: Fix crash in PBXTargetDependency. #107

Merged
merged 1 commit into from
Aug 10, 2023
Merged

xcodeproj_extensions: Fix crash in PBXTargetDependency. #107

merged 1 commit into from
Aug 10, 2023

Conversation

byohay
Copy link
Collaborator

@byohay byohay commented Aug 9, 2023

The crash happens when target_proxy is nil.

@byohay
xcodeproj_extensions: Fix crash in PBXTargetDependency.
836dbe8 
The crash happens when `target_proxy` is `nil`.
@byohay byohay linked an issue Aug 9, 2023 that may be closed by this pull request
undefined method `to_tree_hash' for nil:NilClass (NoMethodError) #106
Closed
ashdnazg
ashdnazg approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@ashdnazg ashdnazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@byohay byohay merged commit 64d5aa6 into main Aug 10, 2023
1 check passed
@byohay byohay deleted the feature/fix-nil-to-tree-hash branch August 10, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashdnazg ashdnazg ashdnazg approved these changes

Assignees

@ashdnazg ashdnazg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

undefined method `to_tree_hash' for nil:NilClass (NoMethodError)
2 participants
@byohay @ashdnazg