apply_change_to_project: Raise on project reference without file. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashdnazg
requested changes
Mar 7, 2022
| @@ -524,6 +524,12 @@ def add_subproject_reference(root_object, project_reference_change) | |||
| find_file(root_object.project, project_reference_change["ProjectRef"], | |||
| file_filter: filter_subproject_without_project_references) | |||
|
|
|||
| unless subproject_reference | |||
| raise MergeError, "No file reference was found for project reference with change " \ | |||
| "#{project_reference_change}. This might mean that the file used to exist in the but " \ | |||
|
F&S&M |
byohay
force-pushed
the
feature/raise-project-reference-without-file
branch
from
dd54b88
to
f718d7f
Compare
|
@ashdnazg fixed (can't merge until you approved) |
ashdnazg
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.