apply_change_to_project: Handle remove configuration list change. #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashdnazg
requested changes
Aug 10, 2022
| elsif change[:removed].is_a?(Array) | ||
| (change[:removed]).each do |removed_change| | ||
| child = | ||
| child_component_of_object_list(component, removed_change, removed_change["displayName"]) |
There was a problem hiding this comment.
this function expects component to be non-nil
| add_child_to_component(is_object_list ? parent_component : component, added_change, | ||
| change_path) | ||
| if change[:added].is_a?(Hash) | ||
| add_child_to_component(parent_component, change[:added], change_path) |
Comment on lines
-214
to
-217
| if component.nil? | ||
| add_missing_component_if_valid(parent_component, change_name, change, change_path) | ||
| return | ||
| end |
There was a problem hiding this comment.
The nullability questions arise from this
byohay
force-pushed
the
feature/handle-remove-configuration-list
branch
from
688d288
to
34367c6
Compare
|
@ashdnazg I added guards around places that need |
ashdnazg
approved these changes
Aug 15, 2022
Also, refactor applying added changes for symmetry with removed changes.
byohay
force-pushed
the
feature/handle-remove-configuration-list
branch
from
34367c6
to
c40e77a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, refactor applying added changes for symmetry with removed changes.