Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default to enable pow #203

Merged
merged 1 commit into from
Jun 27, 2024
Merged

feat: default to enable pow #203

merged 1 commit into from
Jun 27, 2024

Conversation

hunjixin
Copy link
Contributor

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

Provide a one line summary and link to any relevant references

Task/Issue reference

Closes: add_link_here

Details (optional)

Add any additional details that might help Code Reviewers digest this PR

How to test this code? (optional)

Anything else? (optional)

Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's make sure we update all the docs that need updating with this change

@richardbremner
Copy link
Contributor

@AquiGorka we need to make sure we apply the --disable-pow flag on the solver and job-creator, otherwise they'll try to perform PoW too

@hunjixin hunjixin merged commit 44ef08d into main Jun 27, 2024
2 checks passed
@hunjixin hunjixin deleted the feat/default_to_enable_pow branch June 27, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants