feat(install): auto updating binary #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: install notes guide the user through these steps, this code doesn't run in a deployment
AquiGorka
reviewed
Jun 28, 2024
| export OSNAME | ||
|
|
||
| # Get the latest version URL | ||
| LATEST_URL=$(curl -s https://api.github.com/repos/lilypad-tech/lilypad/releases/latest | grep "browser_download_url.*lilypad-$OSNAME-$OSARCH" | cut -d : -f 2,3 | tr -d \") |
There was a problem hiding this comment.
Does this check work with the new things added to binaries? (I mean the binaries with cuda and the ones without)
There was a problem hiding this comment.
We'll want to update this once we have the new releases pipeline in place:
grep "browser_download_url.*lilypad-$OSNAME-$OSARCH"
to
grep "browser_download_url.*lilypad-$OSNAME-$OSARCH-gpu"
Will add that to the releases pipeline PR if we merge this one first.
bgins
approved these changes
Jun 28, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: install notes guide the user through these steps, this code doesn't run in a deployment
Review Type Requested (choose one):
Summary
These files will be used in the installation instructions, to setup the auto updating binary.
Task/Issue reference
Closes: https://github.com/Lilypad-Tech/hni/issues/4
Details (optional)
This PR for doco should be merged after this is merged: Lilypad-Tech/lilypad-docs#42