Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: docker releases and compose file #234

Merged
merged 6 commits into from
Jul 11, 2024
Merged

Conversation

walkah
Copy link
Contributor

@walkah walkah commented Jul 4, 2024

Review Type Requested (choose one):

  • Glance - superficial check (from domain experts)
  • Logic - thorough check (from everybody doing review)

Summary

Provide a one line summary and link to any relevant references

Task/Issue reference

Re: #89

Details (optional)

  • Adds a docker-compose file for development
  • Publishes all docker containers to Github container registry

How to test this code? (optional)

Run the following:

  • ./stack compose-init
  • ./stack compose-up

@github-actions github-actions bot added the build label Jul 4, 2024
@walkah walkah force-pushed the walkah/build-docker-compose branch 2 times, most recently from 74cefcd to f69b4e5 Compare July 9, 2024 15:33
@walkah walkah marked this pull request as ready for review July 9, 2024 20:38
@walkah walkah force-pushed the walkah/build-docker-compose branch from 62a9175 to a83f510 Compare July 10, 2024 14:03
Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I ran ./stack compose-init I got the following:

WARN[0000] The "DOPPLER_TOKEN_SOLVER" variable is not set. Defaulting to a blank string. 
WARN[0000] The "DOPPLER_TOKEN_JOB_CREATOR" variable is not set. Defaulting to a blank string. 

I see it is being set at compose-up time, not really know how to offer a solution, just bringing it to your attention.

Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-10 at 11 50 26 AM

First time I ran ./stack compose-up

@walkah
Copy link
Contributor Author

walkah commented Jul 10, 2024

First time I ran ./stack compose-up

Oh interesting. Looks like building the docker images took longer than the doppler secret 1m timeout. Good to know! I'm new to doppler - any issue bumping that to 10m or something? Or I can add a separate build step...

@walkah
Copy link
Contributor Author

walkah commented Jul 10, 2024

I see it is being set at compose-up time, not really know how to offer a solution, just bringing it to your attention.

harmless warning, but yeah, it's scary. I can make it go away :)

@AquiGorka
Copy link
Contributor

Oh interesting. Looks like building the docker images took longer than the doppler secret 1m timeout. Good to know! I'm new to doppler - any issue bumping that to 10m or something? Or I can add a separate build step...

Let's up the time for those tokens yeah.

Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-07-10 at 11 59 27 AM

On the second run, this time the resource-provider errored because it could not find the solver.
Is there a way to set order of execution and some spare time? Both the job-creator and resource-provider need the solver to have connected to the chain and registered itself.

stack Outdated Show resolved Hide resolved
stack Outdated Show resolved Hide resolved
stack Show resolved Hide resolved
Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍬 🍬 (sweet!)

On the 3rd run all services were up and ready, I ran a cli job, an onchain job and the integration tests and all worked correctly! 🎉
I did leave a comment in regards to make the results from onchain available to the host - maybe, your call if the intention here does not need to make them available as this may be intended for testing purposes.

walkah and others added 4 commits July 10, 2024 16:12
@walkah walkah requested review from AquiGorka and bgins July 10, 2024 21:10
@walkah
Copy link
Contributor Author

walkah commented Jul 10, 2024

Okay, @bgins & @AquiGorka - I've made a bunch of updates based on your feedback, including:

  • adding healthhecks and restarts to make sure services all get started correctly on first boot
  • bumped the timeout on the doppler tokens for fresh initial docker build
  • updated the mountpoint for the rp/bacalhau image so results are accessible in ./data/bacalhau
  • I also added ./stack compose-build (to build fresh images if you're making local changes) and ./stack compose-down to clean up

Thanks for all the feedback! 🙏

@walkah walkah merged commit c43a71c into main Jul 11, 2024
1 check passed
@walkah walkah deleted the walkah/build-docker-compose branch July 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants