-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: docker releases and compose file #234
Conversation
74cefcd
to
f69b4e5
Compare
62a9175
to
a83f510
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First time I ran ./stack compose-init
I got the following:
WARN[0000] The "DOPPLER_TOKEN_SOLVER" variable is not set. Defaulting to a blank string.
WARN[0000] The "DOPPLER_TOKEN_JOB_CREATOR" variable is not set. Defaulting to a blank string.
I see it is being set at compose-up
time, not really know how to offer a solution, just bringing it to your attention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh interesting. Looks like building the docker images took longer than the doppler secret 1m timeout. Good to know! I'm new to doppler - any issue bumping that to 10m or something? Or I can add a separate build step... |
harmless warning, but yeah, it's scary. I can make it go away :) |
Let's up the time for those tokens yeah. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍬 🍬 (sweet!)
On the 3rd run all services were up and ready, I ran a cli
job, an onchain
job and the integration tests
and all worked correctly! 🎉
I did leave a comment in regards to make the results from onchain
available to the host - maybe, your call if the intention here does not need to make them available as this may be intended for testing purposes.
Co-authored-by: Brian Ginsburg <7957636+bgins@users.noreply.github.com>
Okay, @bgins & @AquiGorka - I've made a bunch of updates based on your feedback, including:
Thanks for all the feedback! 🙏 |
Review Type Requested (choose one):
Summary
Provide a one line summary and link to any relevant references
Task/Issue reference
Re: #89
Details (optional)
How to test this code? (optional)
Run the following:
./stack compose-init
./stack compose-up