Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10d9e/initial avalanche testnet #72

Closed
wants to merge 8 commits into from
Closed

Conversation

10d9e
Copy link

@10d9e 10d9e commented Apr 30, 2024

Initial shot at Avalanche-based EVM network, with teleporter and AMW relayer functions baked in

closes https://github.com/Lilypad-Tech/lilypad-q2-pm/issues/8

@10d9e 10d9e requested review from Zorlin and AquiGorka April 30, 2024 23:32
@10d9e 10d9e self-assigned this Apr 30, 2024
@10d9e 10d9e requested a review from developersteve May 1, 2024 17:58
@10d9e 10d9e marked this pull request as ready for review May 1, 2024 17:59
@AquiGorka
Copy link
Contributor

Thank you for doing atomic commits! Makes life so much easier to review and to get in sync with your mental process. On that note a nit: can I ask you to remove that last merge main to your branch commit?
It does not actually introduce anything so for this specific PR it is ok-ish, but other times those merge commits do introduce changes that are unrelated to your PR, that's why I really encourage doing rebase with the main branch.

set -e

curl -sSfL https://raw.githubusercontent.com/ava-labs/avalanche-cli/main/scripts/install.sh | sh -s
export PATH=~/bin:$PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, can we maybe create a local tmp folder here (and git ignore it) to download and execute? I'd rather not modify the dev's path

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, ideally we run this whole thing in a container and just expose the rpc url?

@@ -3,14 +3,30 @@ version: '3.8'
name: lilypad-chain

services:
lilypad-node:
#lilypad-node:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder, let's remove the comment before merging

"VMVersion": "v0.6.3",
"RPCVersion": 35,
"Subnet": "lilypad",
"TokenName": "LILY Token",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be very explicit here: Lilypad Token Development and LPD?

Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @10d9e I don't want this line of work to be blocked or if we are still going to use this, so I'm approving.

@AquiGorka
Copy link
Contributor

Closed as we are moving to Arbitrum

@AquiGorka AquiGorka closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants