Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Johnny #9

Merged
merged 1 commit into from
Sep 4, 2022
Merged

Johnny #9

merged 1 commit into from
Sep 4, 2022

Conversation

Johnnychuan
Copy link
Collaborator

Added new logo, changed background color, and new tooltip on button

Added new logo, changed background color, and new tooltip on button
/* this is a green */
}

.tooltiptext {

Check notice

Code scanning

Rule doesn't have all its properties in alphabetical order.

Rule doesn't have all its properties in alphabetical order.
}

.header img {

Check notice

Code scanning

Rule doesn't have all its properties in alphabetical order.

Rule doesn't have all its properties in alphabetical order.
top: 10px;
width: 60px;
height: 60px;
padding-bottom: 40px;

Check notice

Code scanning

Using height with padding-bottom can sometimes make elements larger than you expect.

Using height with padding-bottom can sometimes make elements larger than you expect.
button {
float: right;
}
#name, #email {

#name,

Check notice

Code scanning

Don't use IDs in selectors.

Don't use IDs in selectors.
#name, #email {

#name,
#email {

Check notice

Code scanning

Don't use IDs in selectors.

Don't use IDs in selectors.
Copy link
Collaborator Author

@Johnnychuan Johnnychuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Designed a logo for the website

@LimSongWei LimSongWei merged commit 4d7cb6d into master Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants