Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unchecked-extrinsic): ecdsa signature verification #303

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

failfmi
Copy link
Collaborator

@failfmi failfmi commented Nov 24, 2023

Detailed description:

  • add EcdsaRecoverCompressed
  • add ecdsa signature verification
  • update goscale to latest to use latest DecodeResult
  • add unit tests
  • add test util helper for ecdsa signing as centrifuge/gossamer do not support extrinsic build with ecdsa signature
  • add integration test

Which issue(s) this PR fixes:
Fixes #67

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@failfmi failfmi self-assigned this Nov 24, 2023
@failfmi failfmi linked an issue Nov 24, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (9f96950) 77.99% compared to head (002b79c) 78.08%.

Files Patch % Lines
primitives/io/crypto.go 0.00% 11 Missing ⚠️
execution/types/unchecked_extrinsic.go 78.57% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
+ Coverage    77.99%   78.08%   +0.08%     
===========================================
  Files          156      157       +1     
  Lines        10363    10431      +68     
===========================================
+ Hits          8083     8145      +62     
- Misses        1908     1914       +6     
  Partials       372      372              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@failfmi failfmi merged commit f4937b4 into develop Nov 27, 2023
5 checks passed
@failfmi failfmi deleted the feat/uxt/check/ecdsa branch November 27, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Ecdsa signature verification
2 participants