-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: logger #315
Merged
Merged
refactor: logger #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #315 +/- ##
===========================================
+ Coverage 78.69% 80.55% +1.85%
===========================================
Files 165 165
Lines 10774 10841 +67
===========================================
+ Hits 8479 8733 +254
+ Misses 1921 1798 -123
+ Partials 374 310 -64 ☔ View full report in Codecov by Sentry. |
Closed
failfmi
reviewed
Dec 18, 2023
failfmi
reviewed
Dec 21, 2023
failfmi
previously approved these changes
Jan 2, 2024
radkomih
previously approved these changes
Jan 2, 2024
The merge-base changed after approval.
failfmi
approved these changes
Jan 2, 2024
radkomih
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
Introduce logger as a dependency and only do critical logging(panic) in api modules
Which issue(s) this PR fixes:
Fixes #294
Special notes for your reviewer:
Checklist