Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: logger #315

Merged
merged 7 commits into from
Jan 2, 2024
Merged

refactor: logger #315

merged 7 commits into from
Jan 2, 2024

Conversation

tgntr
Copy link
Collaborator

@tgntr tgntr commented Dec 18, 2023

Detailed description:
Introduce logger as a dependency and only do critical logging(panic) in api modules
Which issue(s) this PR fixes:
Fixes #294

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (2465c13) 78.69% compared to head (d666541) 80.55%.

Files Patch % Lines
frame/system/limits.go 0.00% 30 Missing ⚠️
primitives/log/logger_nonwasm.go 79.48% 8 Missing ⚠️
frame/system/extensions/check_weight.go 77.77% 4 Missing ⚠️
...n_payment/extensions/charge_transaction_payment.go 71.42% 4 Missing ⚠️
execution/types/unchecked_extrinsic.go 85.71% 3 Missing ⚠️
frame/balances/module.go 50.00% 2 Missing and 1 partial ⚠️
execution/extrinsic/runtime_extrinsic.go 90.47% 1 Missing and 1 partial ⚠️
api/block_builder/module.go 94.11% 1 Missing ⚠️
api/genesis_builder/module.go 88.88% 1 Missing ⚠️
api/metadata/module.go 75.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #315      +/-   ##
===========================================
+ Coverage    78.69%   80.55%   +1.85%     
===========================================
  Files          165      165              
  Lines        10774    10841      +67     
===========================================
+ Hits          8479     8733     +254     
+ Misses        1921     1798     -123     
+ Partials       374      310      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@failfmi failfmi linked an issue Dec 18, 2023 that may be closed by this pull request
execution/extrinsic/runtime_extrinsic_test.go Outdated Show resolved Hide resolved
execution/extrinsic/runtime_extrinsic_test.go Outdated Show resolved Hide resolved
execution/extrinsic/runtime_extrinsic_test.go Outdated Show resolved Hide resolved
execution/extrinsic/runtime_extrinsic_test.go Outdated Show resolved Hide resolved
primitives/log/logger.go Outdated Show resolved Hide resolved
execution/extrinsic/runtime_extrinsic_test.go Outdated Show resolved Hide resolved
@tgntr tgntr requested a review from failfmi December 21, 2023 07:10
@tgntr tgntr changed the title Refactor logger refactor: logger Dec 22, 2023
failfmi
failfmi previously approved these changes Jan 2, 2024
radkomih
radkomih previously approved these changes Jan 2, 2024
@tgntr tgntr dismissed radkomih’s stale review January 2, 2024 10:40

The merge-base changed after approval.

@failfmi failfmi self-requested a review January 2, 2024 10:48
@tgntr tgntr merged commit 7ac3439 into develop Jan 2, 2024
5 checks passed
@tgntr tgntr deleted the refactor/logger branch January 2, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor logger
3 participants