Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): execute_block #41

Merged
merged 13 commits into from
Feb 14, 2023
Merged

feat(core): execute_block #41

merged 13 commits into from
Feb 14, 2023

Conversation

failfmi
Copy link
Collaborator

@failfmi failfmi commented Feb 14, 2023 •
edited
Loading

Detailed description:

  • fix storage.Get retrieval
  • fix extrinsic index in apply_extrinsic and finalize_block
  • fix finalize_block encoding
  • switch extrinsics hashing to use trie_blake2_256_ordered_root

Which issue(s) this PR fixes:
Fixes #6

Special notes for your reviewer:

  • storage.Get to Option will be refactored in a separate PR
  • will add additional asserts + ExecuteBlock test in the next hour

Checklist

  • Documentation added
  • Tests updated

@failfmi failfmi self-assigned this Feb 14, 2023
radkomih
radkomih previously approved these changes Feb 14, 2023
View reviewed changes
@failfmi failfmi merged commit eee61e4 into master Feb 14, 2023
@failfmi failfmi deleted the feat/core/execute-block branch February 14, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radkomih radkomih radkomih approved these changes

Assignees

@failfmi failfmi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of Core_execute_block
2 participants
@failfmi @radkomih