Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage/get): parse option and add generic get/take #43

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

failfmi
Copy link
Collaborator

@failfmi failfmi commented Feb 15, 2023

Detailed description:

  • Refactor storage.Get to return Option<slice>
  • Add GetDecode
  • Add TakeBytes
  • Add TakeDecode

Which issue(s) this PR fixes:
Fixes #39

Special notes for your reviewer:

  • In case there is some need to add Option<T>, we can add it later on.

Checklist

  • Documentation added
  • Tests updated

@failfmi failfmi self-assigned this Feb 15, 2023
@failfmi failfmi merged commit d0eed06 into master Feb 15, 2023
@failfmi failfmi deleted the refactor/storage/get branch February 15, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat every ext_storage_get result as Optional<any>
2 participants