Refactoring: Scheduled Sign #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
georgiyazovaliiski
requested review from
Daniel-K-Ivanov,
joan41868,
CordonaCodeCraft and
alshapi
joan41868
reviewed
Sep 24, 2021
Comment on lines
80
to
87
| var outcome = signingOutcome.getLeft(); | ||
| if (outcome == OK) { | ||
| var updatedSchedule = store.get(scheduleId); | ||
| txnCtx.setScheduledTxnId(updatedSchedule.scheduledTransactionId()); | ||
| txnCtx.setScheduledTxnId(schedule.scheduledTransactionId()); | ||
| if (signingOutcome.getRight()) { | ||
| outcome = executor.processExecution(scheduleId, store, txnCtx); | ||
| schedule.execute(txnCtx, store::resetPendingCreation); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
The previous execution outcome was coming from the executor.processExecution method. We must think of a solution to either:
- set the status in
schedule.executemethod - assume it's successful ( it throws
InvalidTransactionExceptionon fail )
There was a problem hiding this comment.
Let's also check SignatoryUtils for something buggy
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
…gn-internal # Conflicts: # hedera-node/src/main/java/com/hedera/services/store/models/Schedule.java # hedera-node/src/main/java/com/hedera/services/store/schedule/ScheduleModelStore.java # hedera-node/src/main/java/com/hedera/services/txns/schedule/ScheduleCreateTransitionLogic.java # hedera-node/src/main/java/com/hedera/services/txns/schedule/ScheduleSignTransitionLogic.java # hedera-node/src/test/java/com/hedera/services/txns/schedule/ScheduleSignTransitionLogicTest.java
Signed-off-by: Georgi Yazovaliyski <georgi.yazovaliiski@gmail.com>
Petyo-Lukanov
added
refactoring
joan41868
reviewed
Oct 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Scheduled Sign Transition Logic refactoring concluded in using the new refactored infrastructure, along with the Schedule model class. Unit tests were updated. E2E tests are passing.
Signed-off-by: Georgi Yazovaliyski georgi.yazovaliiski@gmail.com