18337: Placeholders VALIDFROM and VALIDUNTIL at email templates do not use localized dates

[gabrieljenik]

Tests for localize_date were added

[Shnoulle]

Seems you don't use lss file, if not : \Yii::import('application.core.plugins.dateFunctions.EMFunctions', true); is great just remove the lss file and import.

If yes : use included function and helper for activate plugin and import survey

[gabrieljenik]

Seems you don't use lss file

I do use it.

If yes : use included function and helper for activate plugin and import survey

I import LSS as needed to run the test
Call plugin function directly.

What's wrong with current way?

[Shnoulle]

I import LSS as needed to run the test

I don't understand : you don't use lss file here. Best is to be clear : this test don't do WebDriver. The lss file is not needed.

[Shnoulle]

Seems you don't use lss file

I do use it.

Where ? I really think you don't use it. Maybe i made an error , but looking at code : you don't use it.

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
10 Code Smells

0.0% Coverage
0.0% Duplication

[Shnoulle]

👍

[gabrieljenik]

@olleharstedt Being this an automated test, should I markit as tested now that is green?

[olleharstedt]

@olleharstedt Being this an automated test, should I markit as tested now that is green?

Hmmm maybe we should add a new tag for automated test added?