Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for label translation domain #15

Merged
merged 1 commit into from
Nov 6, 2017

Conversation

grimpows
Copy link
Contributor

i created issue in liform bundle repo : Limenius/LiformBundle#4
this is the PR for solve it :) this had check of form use a translation doomain (like FOSUser do) and use it to translate form label ! :)

@nacmartin nacmartin merged commit 4a0f95c into Limenius:master Nov 6, 2017
@nacmartin
Copy link
Member

Oh, very nice, thanks @grimpows

@grimpows
Copy link
Contributor Author

grimpows commented Nov 7, 2017

np @nacmartin but keep in mind that i didnt apply any change for placeholder. i have to learn a bit more about redux form and how using template for liform react as i dont want tu use bootstrap as default form template ^^. i'll try to make PR as often as i can, thanks again for your great bundles 👍

@nacmartin
Copy link
Member

I understand. The issue is that we have our theme for very specific widgets, which was the reason behind this. We don't use the full specification (I don't think we need for instance dates), but we have widgets that are tables with turns for workers, or choices displayed as big buttons with icons (season winter/spring/summer/autumn with their icons) and things like that. So in short, it is not a general purpose theme.

So we provide a theme based on bootstrap instead and there is the possibility of extending it.

There is a theme based on Material UI written by another user, for instance, also supporting a subset of the widgets afaik https://github.com/samuelbriole/react-liform-material-ui-theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants