Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homeassistant.util.temperature is deprecated, need to remove convert usage #126

Closed
3 tasks done
elad-bar opened this issue Oct 29, 2023 · 5 comments · Fixed by #128, jacobgeisel/ha-iaquk#1 or robvanoostenrijk/ha-iaquk#1

Comments

@elad-bar
Copy link

Checklist

  • I have filled out the template to the best of my ability.
  • This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
  • This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.

Effective 2023.11.x - homeassistant.util.temperature will be deprecated, working with RC version leads to integration loading failure

Describe the solution you'd like

HA knows how to handle unit conversion using the UI, it seems like redundant functionality - Line 356, 357 in init.py

Describe alternatives you've considered

no other option

Additional context

link to functionality deprecation commit:
home-assistant/core@8626a48

@McGiverGim
Copy link

I can confirm the issue with the version of HA released today.

lafriks added a commit to lafriks/ha-iaquk that referenced this issue Nov 1, 2023
Removes usage of deprecated and in latest version removed function.

Fixes Limych#126
@billmaterial
Copy link

I have implemented a quick workaround for this issue until the official fix is implemented.

  1. Copy "temperature.py" to the "custom_components > iaquk" folder (I downloaded one from Github from the utils folder).
  2. Change line 12 of "temperature.py" from "from .unit_conversion import TemperatureConverter" to "from homeassistant.util.unit_conversion import TemperatureConverter".
  3. Edit "init.py" and change line 30 to "from .temperature import convert as convert_temperature".
  4. Check config and restart.

That has got it working again for me.
iaquk-temp-fix.zip

@elad-bar
Copy link
Author

elad-bar commented Nov 2, 2023

I've done something similar,
Removed the import and the usage of it, mainly because it's should noy handle the conversion by component as this is out of the box capability

@cinghialino
Copy link

is this project abandoned? Has the author been drafted? Hopefully they're fine.

@AlexL00
Copy link

AlexL00 commented Nov 26, 2023

is this project abandoned? Has the author been drafted? Hopefully they're fine.

The author @Limych seems to be active in another project 4 days ago. So at least we know they're still there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants