Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MyPerf4J-87] Fix windows env getConfigFileDir is empty #87 #88

Merged
merged 3 commits into from
Apr 1, 2023

Conversation

JiaRG
Copy link
Contributor

@JiaRG JiaRG commented Mar 28, 2023

What is the purpose of the change

fix #87

Brief ChangeLog

Fix windows env getConfigFileDir is empty

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [MyPerf4J-XXX] Fix NullPointerException when host is null #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist.
  • Run mvn clean package -Dmaven.test.skip=false to make sure unit-test pass.

@LinShunKang LinShunKang merged commit 52ed1cf into LinShunKang:develop Apr 1, 2023
@LinShunKang
Copy link
Owner

Thanks : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window环境下配置文件路径获取错误
2 participants